Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test cask macOS dependency #7800

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix test cask macOS dependency #7800

merged 1 commit into from
Jun 23, 2020

Conversation

gromgit
Copy link
Contributor

@gromgit gromgit commented Jun 23, 2020

Closes #7777.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix test cask macOS dependency
6044bb1 
This should be updated when the minimum OS requirement changes.
issyl0
issyl0 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - caffeine does work on Yosemite - thanks @gromgit!

@issyl0 issyl0 merged commit 2d54b9b into Homebrew:master Jun 23, 2020
@MikeMcQuaid
Copy link
Member

Thanks @gromgit!

@gromgit gromgit deleted the fix_brew_tests branch June 23, 2020 13:05
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew tests requires Catalina or newer?
4 participants
@gromgit @MikeMcQuaid @issyl0 @BrewTestBot