-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Big Sur tweaks #7806
macOS Big Sur tweaks #7806
Conversation
Library/Homebrew/os/mac/version.rb
Outdated
big_sur: "10.16", | ||
big_sur: "11.00", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MacOS.version
returns 10.16 on Intel (for now) so any comparisons will not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for converting the symbol to the version so I think it's still the right thing here. We'll likely need some custom comparison logic too to know that 10.16 == 11.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also affects Cask definitions, which currently use the >=
operator for depends_on
(example).
/cc @vitorgalvao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it conditional on ARM/Intel for now.
Shouldn't we also update the CLT versions too? |
- output warnings when running on ARM - require Xcode 12 - use 11.0 as the version number
@Bo98 Do you know them yet? |
Merging and we can add more stuff in follow-up PRs. |
A simple 12.0.0 should be sufficient for the minimum version. For the latest Clang version, it's 1200.0.22.7. |
require "version" | ||
|
||
module OS | ||
module Mac | ||
class Version < ::Version | ||
SYMBOLS = { | ||
big_sur: "10.16", | ||
big_sur: Hardware::CPU.arm? ? "11.00" : "10.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really 11.00
and not 11.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened PR #7810
brew style
with your changes locally?brew tests
with your changes locally?