Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Big Sur tweaks #7806

Merged
merged 1 commit into from
Jun 23, 2020
Merged

macOS Big Sur tweaks #7806

merged 1 commit into from
Jun 23, 2020

Conversation

MikeMcQuaid
Copy link
Member

  • output warnings when running on ARM
  • require Xcode 12
  • use 11.0 as the version number

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

big_sur: "10.16",
big_sur: "11.00",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS.version returns 10.16 on Intel (for now) so any comparisons will not work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for converting the symbol to the version so I think it's still the right thing here. We'll likely need some custom comparison logic too to know that 10.16 == 11.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also affects Cask definitions, which currently use the >= operator for depends_on (example).

/cc @vitorgalvao

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it conditional on ARM/Intel for now.

@Bo98
Copy link
Member

Bo98 commented Jun 23, 2020

Shouldn't we also update the CLT versions too?

- output warnings when running on ARM
- require Xcode 12
- use 11.0 as the version number
@MikeMcQuaid
Copy link
Member Author

Shouldn't we also update the CLT versions too?

@Bo98 Do you know them yet?

@MikeMcQuaid MikeMcQuaid merged commit d6cc5ff into Homebrew:master Jun 23, 2020
@MikeMcQuaid
Copy link
Member Author

Merging and we can add more stuff in follow-up PRs.

@MikeMcQuaid MikeMcQuaid deleted the big_sur_tweaks branch June 23, 2020 13:31
@Bo98
Copy link
Member

Bo98 commented Jun 23, 2020

A simple 12.0.0 should be sufficient for the minimum version.

For the latest Clang version, it's 1200.0.22.7.

require "version"

module OS
module Mac
class Version < ::Version
SYMBOLS = {
big_sur: "10.16",
big_sur: Hardware::CPU.arm? ? "11.00" : "10.16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really 11.00 and not 11.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened PR #7810

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants