Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkage_checker: handle system libraries on Big Sur #7817

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jun 24, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

From macOS Big Sur 11 Beta Release Notes:

New in macOS Big Sur 11 beta, the system ships with a built-in dynamic linker cache of all system-provided libraries. As part of this change, copies of dynamic libraries are no longer present on the filesystem. Code that attempts to check for dynamic library presence by looking for a file at a path or enumerating a directory will fail. Instead, check for library presence by attempting to dlopen() the path, which will correctly check for the library in the cache. (6298628)

@Bo98 Bo98 force-pushed the big-sur-system-linkage branch from d3c7871 to 9c4aaa9 Compare June 24, 2020 15:28
@MikeMcQuaid
Copy link
Member

Wow, surprisingly easy. Well done @Bo98 👏

@MikeMcQuaid MikeMcQuaid merged commit be2dd90 into Homebrew:master Jun 24, 2020
@Bo98 Bo98 deleted the big-sur-system-linkage branch June 24, 2020 16:06
@Bo98
Copy link
Member Author

Bo98 commented Jun 24, 2020

Thank goodness Fiddle existed!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 27, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants