Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_user_path_1: Fix message presentation #8002

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

gromgit
Copy link
Contributor

@gromgit gromgit commented Jul 14, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This turns the misordered:

$ PATH=/usr/bin:$PATH brew doctor
Warning: /usr/bin occurs before /usr/local/bin
This means that system-provided programs will be used instead of those
provided by Homebrew. The following tools exist at both paths:

Consider setting your PATH so that /usr/local/bin
occurs before /usr/bin. Here is a one-liner:
  echo 'export PATH="/usr/local/bin:$PATH"' >> /Users/gromgit/.bash_profile
  xzless
  javap
  renice

into the more correct:

$ PATH=/usr/bin:$PATH brew doctor
Warning: /usr/bin occurs before /usr/local/bin
This means that system-provided programs will be used instead of those
provided by Homebrew. Consider setting your PATH so that
/usr/local/bin occurs before /usr/bin. Here is a one-liner:
  echo 'export PATH="/usr/local/bin:$PATH"' >> /Users/aho/.bash_profile

The following tools exist at both paths:
  xzless
  javap
  renice

@gromgit gromgit force-pushed the fix_diag_wording branch from a9a12ae to 567b5a9 Compare July 14, 2020 10:57
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit b931f50 into Homebrew:master Jul 14, 2020
@gromgit gromgit deleted the fix_diag_wording branch July 18, 2020 15:40
@MikeMcQuaid
Copy link
Member

Nice catch!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants