Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: use GITHUB_TOKEN when checking license #8025

Merged
merged 1 commit into from
Jul 17, 2020
Merged

workflows: use GITHUB_TOKEN when checking license #8025

merged 1 commit into from
Jul 17, 2020

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Jul 17, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should avoid errors from rate limited API calls when using hosted runners.

@Bo98
Copy link
Member

Bo98 commented Jul 17, 2020

Hmm, if there's going to be potential API errors then maybe me relying on --fail-if-changed will be a bad idea. I guess we should have --success-if-changed or something.

@jonchang
Copy link
Contributor Author

Ah, to be clear, it's not an API error, just rate limiting from not using an authenticated API call. See https://github.com/Homebrew/brew/runs/881647497?check_suite_focus=true#step:12:8 for what I mean.

@jonchang jonchang merged commit 4765814 into Homebrew:master Jul 17, 2020
@jonchang jonchang deleted the token-for-license branch July 17, 2020 12:11
@Bo98
Copy link
Member

Bo98 commented Jul 17, 2020

Sure, though I don't trust GitHub uptime.

@jonchang
Copy link
Contributor Author

If GitHub is down we'd probably have problems in addition to the rate limited test 😅

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants