Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: cleanup #8043

Merged

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#8004, #8022

  • Dropped the word probably in error messages
  • Removed all devel logic since it's deprecated
  • -    return unless guesses.count > 1
    +    return if guesses.count <= 1
  • -    version ||= Version.detect(url, tag ? { tag: tag } : {})
    +    unless version
    +      specs = tag ? { tag: tag } : {}
    +      version = Version.detect(url, specs)
    +    end

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then good to go. Thanks!

Comment on lines 496 to 498
specs = tag ? { tag: tag } : {}
version = Version.detect(url, specs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
specs = tag ? { tag: tag } : {}
version = Version.detect(url, specs)
specs = {}
specs[:tag] = tag if tag
version = Version.detect(url, specs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think of that, nice

@SeekingMeaning SeekingMeaning force-pushed the bump-formula-pr-cleanup branch from ab58db6 to e5cc33a Compare July 20, 2020 15:16
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the follow-up PR and I'm 👍 to merge when you are.

@SeekingMeaning SeekingMeaning merged commit ab39e62 into Homebrew:master Jul 22, 2020
@SeekingMeaning SeekingMeaning deleted the bump-formula-pr-cleanup branch July 22, 2020 17:44
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants