Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/disable code for Homebrew 2.5.0. #8513

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Deprecate/disable code for Homebrew 2.5.0. #8513

merged 1 commit into from
Sep 3, 2020

Conversation

MikeMcQuaid
Copy link
Member

Do the usual "disable deprecations" and "uncomment pending deprecations" dance and delete/deprecate/disable relevant/related code.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member Author

@SeekingMeaning Once we've nailed down some new names I'll add (or uncomment) the odeprecated lines in here ☝🏻

Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
@MikeMcQuaid MikeMcQuaid merged commit 3c48357 into Homebrew:master Sep 3, 2020
@MikeMcQuaid MikeMcQuaid deleted the 2.5-deprecations branch September 3, 2020 10:09
kdeldycke added a commit to kdeldycke/meta-package-manager that referenced this pull request Sep 13, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants