Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_config.rb: show system Ruby info on Linux #8591

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

maxim-belkin
Copy link
Contributor

I propose to report the version of system Ruby in config as this info might be helpful for debugging purposes.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member

This should be Linux only (i.e. in os/extend) as we're not gonna use this on macOS.

@maxim-belkin maxim-belkin changed the title system_config.rb: show system Ruby info system_config.rb: show system Ruby info on Linux Sep 4, 2020
@MikeMcQuaid MikeMcQuaid merged commit 7710670 into Homebrew:master Sep 4, 2020
@MikeMcQuaid
Copy link
Member

Thanks for this @maxim-belkin!

@maxim-belkin maxim-belkin deleted the system-ruby-config branch September 4, 2020 17:58
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants