Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore FormulaUnreadableError in Formula.each. #8592

Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 3, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes Cask CI error. (Homebrew/homebrew-cask#88669)

@reitermarkus reitermarkus changed the title Ignore MethodDeprecatedError in Formula.each. Ignore FormulaUnreadableError in Formula.each. Sep 3, 2020
@reitermarkus reitermarkus force-pushed the desc-cache-ignore-exceptions branch from 5f31459 to 8fb769e Compare September 3, 2020 17:48
Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxim-belkin
Copy link
Contributor

Tested locally - it works, that is: I see tracebacks like this

/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FromPathLoader): loading /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/maxim-belkin/homebrew-core/Formula/l-smash.rb
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:2772:in `disable!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/maxim-belkin/homebrew-core/Formula/l-smash.rb:25:in `<class:LSmash>'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/maxim-belkin/homebrew-core/Formula/l-smash.rb:1:in `load_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:44:in `module_eval'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:44:in `load_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:65:in `load_formula_from_path'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:150:in `load_file'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:140:in `klass'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:136:in `get_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formulary.rb:347:in `factory'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:1463:in `block in each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:1462:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula.rb:1462:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/description_cache_store.rb:37:in `populate_if_empty!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/description_cache_store.rb:63:in `update_from_formula_names!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/tap.rb:297:in `block in install'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cache_store.rb:17:in `use'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/tap.rb:295:in `install'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/tap.rb:64:in `tap'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'
Error: Failed to import: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/maxim-belkin/homebrew-core/Formula/l-smash.rb
l-smash: Calling `disable!` without a reason is deprecated! Use `disable! because: "reason"` instead.
Please report this issue to the maxim-belkin/core tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/maxim-belkin/homebrew-core/Formula/l-smash.rb:25

but brew tap homebrew/cask succeeds.

@reitermarkus reitermarkus merged commit 2dbaaf3 into Homebrew:master Sep 3, 2020
@reitermarkus reitermarkus deleted the desc-cache-ignore-exceptions branch September 3, 2020 18:21
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants