Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: autodetect license from GitHub when available #8597

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

When a user provides a GitHub repository as the url when creating a new formula, brew currently retrieves the desciption and homepage to pre-populate the formula. This change will now also check to see if a license is present, and if it is, add that to the formula.

@MikeMcQuaid MikeMcQuaid merged commit 5588beb into Homebrew:master Sep 4, 2020
@MikeMcQuaid
Copy link
Member

Thanks @dtrodrigues, good idea!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants