Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: deprecate!/disable!: deprecate missing or non-ISO 8601 dates. #9478

Merged
merged 1 commit into from
Dec 18, 2020
Merged

formula: deprecate!/disable!: deprecate missing or non-ISO 8601 dates. #9478

merged 1 commit into from
Dec 18, 2020

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Dec 9, 2020 •
edited
Loading

As requested in Homebrew/homebrew-core#66360.

Do not merge until we're ready to tag 2.7.0.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-10 at 11:03:42 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 9, 2020
@MikeMcQuaid MikeMcQuaid added do not merge and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 9, 2020
@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 9, 2020
Closed
@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 9, 2020
@Rylan12
Copy link
Member

Rylan12 commented Dec 9, 2020

There might be some value in adding a style check until 2.7.0. Not sure how often we disable/deprecate formulae but given that we just released 2.6.0 it feels like this will be sitting here for a while

@Rylan12 Rylan12 closed this Dec 9, 2020
@Rylan12 Rylan12 reopened this Dec 9, 2020
@Rylan12
Copy link
Member

Rylan12 commented Dec 9, 2020

Sorry, fat fingers 🤦

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Dec 9, 2020
@MikeMcQuaid
Copy link
Member Author

There might be some value in adding a style check until 2.7.0. Not sure how often we disable/deprecate formulae but given that we just released 2.6.0 it feels like this will be sitting here for a while

2.7.0 will probably be a bit quicker than the wait from 2.6.0 because we've got a few pending deprecations queued up.

@Rylan12
Copy link
Member

Rylan12 commented Dec 9, 2020

Okay. It's probably not a huge deal, anyway. We can always batch-add dates to deprecate! and disable! when the time comes if needed, so that's fine.

@MikeMcQuaid
Copy link
Member Author

We can always batch-add dates to deprecate! and disable! when the time comes if needed, so that's fine.

@fxcoudert has already done that in Homebrew/homebrew-core#66549 🎉

Rylan12
Rylan12 reviewed Dec 9, 2020
View reviewed changes
Rylan12
Rylan12 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and appears to work as expected.

CI failures will be resolved elsewhere

@fxcoudert fxcoudert mentioned this pull request Dec 9, 2020
Merged
@fxcoudert
Copy link
Member

@MikeMcQuaid sorry I think you'll need to force push again, I found one formula I had missed: Homebrew/homebrew-core#66564

@Rylan12
Copy link
Member

Rylan12 commented Dec 9, 2020

Rerunning the job should be enough because CI pulls in the latest master branch from homebrew-core.

May as well wait until it's merged into linuxbrew-core as well. Plus, if this is waiting for 2.7.0, it should probably be rebased again then anyway

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 10, 2020
@MikeMcQuaid MikeMcQuaid merged commit 4dfcf74 into Homebrew:master Dec 18, 2020
@MikeMcQuaid MikeMcQuaid deleted the deprecate-disable-date branch December 18, 2020 12:15
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeMcQuaid @BrewTestBot @Rylan12 @fxcoudert