Keep implicit taps #1495
Merged
Keep implicit taps #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Nov 11, 2024
MikeMcQuaid
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Looks good, thanks @tt! One small tweak and we should be good to go.
MikeMcQuaid
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Thanks so much for your great, first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @tt!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a Brewfile that contains the following line:
Running
brew bundle cleanup --verboseincludes the following output:However, this tap can't be removed as the fomula depends on it.
Considering you can install formulae without explicitly adding a
tapdeclaration, it seems that these should be respected when computing which taps to keep.This change does that: Any tap found in a
brewdeclaration will automatically be kept.