-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update printrun from 1.6.0 to 2.0.0rc8 #104184
Conversation
CI failed because of the missing description. I didn't thought about this since I only meant to create a version bump. |
Or maybe a description such as |
I guess |
Thank you for the reminder @cbrockschmidt ! I just added this description to the PR. |
Does somebody know, why the CI is failing? When I execute brew audit, the test passes. % brew audit --cask Casks/printrun.rb
audit for printrun: passed |
I just ran it locally myself. It fails when you run On another note: This seems to be a pre-release version, so |
Interestingly, it installed perfectly without any problems. You are right: it's a pre release version. I'm not sure how such a situation should be handled. Should I close this PR? Or would it make sense to keep it alive with the goal of fixing the application by using a RC version? |
I guess it would be up to Homebrew members' decision based on documented But There Is No Stable Version! Printrun has an open discussion/PR for 2.0.0 release with 2.0.0rc8 being close to ready: kliment/Printrun#1069 The CI failure seems to be due to livecheck regex not matching anything. One worry is Printrun's inconsistency in asset naming.
|
/rebase |
1 similar comment
/rebase |
@vitorgalvao this will need to be re-named, correct? |
@miccal Correct. |
Comments:
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}
is error-free.brew style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask {{cask_file}}
worked successfully.brew install --cask {{cask_file}}
worked successfully.brew uninstall --cask {{cask_file}}
worked successfully.