Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update printrun from 1.6.0 to 2.0.0rc8 #104184

Merged
merged 5 commits into from
May 7, 2021
Merged

Conversation

MayNiklas
Copy link
Contributor

Comments:

  • the old version (1.6.0) doesn't run on 64bit computers -> update to 2.0.0rc8 is needed for the app to work!
  • the name of the binary changed to pronterface -> maybe we could rename the cask?
  • structure of releases changed -> I had to modify the URL
  • cask successfully installed on my computer

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@MayNiklas
Copy link
Contributor Author

CI failed because of the missing description. I didn't thought about this since I only meant to create a version bump.
Would it be okay, to add Pronterface, Pronsole, and Printcore - Pure Python 3d printing host software?
It's how the software describes itself within "about": https://github.com/kliment/Printrun
I don't really know how to describe it in a better way.

@MayNiklas
Copy link
Contributor Author

Or maybe a description such as control your 3D printer from your PC would be fitting better?

@cbrockschmidt
Copy link
Contributor

cbrockschmidt commented Apr 17, 2021

I guess control your 3D printer from your PC would be more fitting, as the desc-stanza documentation tells that a cask's name should not be included in its description.

@MayNiklas
Copy link
Contributor Author

I guess control your 3D printer from your PC would be more fitting, as the desc-stanza documentation tells that a cask's name should not be included in its description.

Thank you for the reminder @cbrockschmidt ! I just added this description to the PR.

@MayNiklas
Copy link
Contributor Author

Does somebody know, why the CI is failing? When I execute brew audit, the test passes.

% brew audit --cask Casks/printrun.rb
audit for printrun: passed

@cbrockschmidt
Copy link
Contributor

cbrockschmidt commented Apr 17, 2021

I just ran it locally myself. It fails when you run brew audit --cask --online printrun. Not sure why though. It fails without your changes too, so I think something broke between the two releases...

On another note: This seems to be a pre-release version, so homebrew-cask might not be the right place for this version as the homebrew-cask tap only accepts stable versions. Beta/pre-release versions can be submitted to homebrew-cask-versions per the documentation.

@MayNiklas
Copy link
Contributor Author

I just ran it locally myself. It fails when you run brew audit --cask --online printrun. Not sure why though. It fails without your changes too, so I think something broke between the to releases...

On another note: This seems to be a pre-release version, so homebrew-cask might not be the right place for this version as the homebrew-cask tap only accepts stable versions. Beta/pre-release versions can be submitted to homebrew-cask-versions per the documentation.

Interestingly, it installed perfectly without any problems.

You are right: it's a pre release version.
BUT: 1.6 only works on Mac's with 32bit support -> the current version within this repository is broken and won't work.
There isn't a non release candidate version with 64bit support yet.

I'm not sure how such a situation should be handled. Should I close this PR? Or would it make sense to keep it alive with the goal of fixing the application by using a RC version?

@cho-m
Copy link
Member

cho-m commented Apr 18, 2021

I guess it would be up to Homebrew members' decision based on documented But There Is No Stable Version!

Printrun has an open discussion/PR for 2.0.0 release with 2.0.0rc8 being close to ready: kliment/Printrun#1069


The CI failure seems to be due to livecheck regex not matching anything.


One worry is Printrun's inconsistency in asset naming.
So far, every macOS zip/dmg has used a different name format.
If this continues, this will result in Homebrew maintenance overhead as URL/regex/etc will need manual modification.

Version Name
2.0.0rc8 pronterface-macos-app-2.0.0rc8.zip
2.0.0rc7 Printrun-2.0.0rc7-macos.zip
2.0.0rc5 pronterface-mac-2.0.0rc5.zip, Printrun-mac-2.0.0rc5.dmg
1.6.0 Printrun-Mac-18Nov2017.zip

@reitermarkus
Copy link
Member

/rebase

1 similar comment
@reitermarkus
Copy link
Member

/rebase

Casks/printrun.rb Outdated Show resolved Hide resolved
@cho-m cho-m added the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label May 5, 2021
@BrewTestBot BrewTestBot removed the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label May 5, 2021
@miccal
Copy link
Contributor

miccal commented May 6, 2021

@vitorgalvao this will need to be re-named, correct?

@vitorgalvao
Copy link
Contributor

@miccal Correct.

@miccal miccal merged commit 1545060 into Homebrew:master May 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants