hook: Fix download with fake user agent #106972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
BrewTestBot
removed
the
ci-requeue
cho-m
approved these changes
Jun 12, 2021
There was a problem hiding this comment.
Thanks, @n-thumann
Merging this as hook cask install is currently broken without it.
The livecheck user-agent issue can be dealt with after we decide what is the best way to fix in Homebrew/brew.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106899.
After making all changes to a cask, verify:
brew audit --cask <cask>is error-free.brew style --fix <cask>reports no offenses.