-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update crushftp from 9 to 10 #109237
Update crushftp from 9 to 10 #109237
Conversation
Casks/crushftp.rb
Outdated
sha256 :no_check # required as upstream package is updated in-place | ||
|
||
url "https://www.crushftp.com/CrushFTP#{version}_OSX.zip" | ||
url "https://www.crushftp.com/early#{version}/CrushFTP#{version}.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't sound like a stable version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 9 also follows this format: https://www.crushftp.com/early9/CrushFTP9.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've written to CrushFTP's support and this is their answer:
Hi,
It's not early. We kept that naming convention from version 6 and so on.
It's in production at many companies already without issues.
They can use CrushFTP.com and go to the download page and download from there as well, even though in the backend it goes to the same location.
In 30 years of CrushFTP existence you are the first client to complain of that naming convention. :)
It might be some limitation of the application they use to get CrushFTP installed.
On what OS do they want to install CrushFTP under?
Thanks,
Arpad
To view ticket history please follow the link:
https://support.crushftp.com/support/ticket_g94hGE0htv4bES2v
Casks/crushftp.rb
Outdated
sha256 :no_check # required as upstream package is updated in-place | ||
|
||
url "https://www.crushftp.com/CrushFTP#{version}_OSX.zip" | ||
url "https://www.crushftp.com/early#{version}/CrushFTP#{version}.zip", | ||
cookies: { "CrushAuth" => "1234567890123_1234567890ABCDEFGHIJKLMNOPQRST" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this will work as it changes for each curl
request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miccal @FnControlOption
From my testing, I could not get the download to complete locally with brew fetch
e687db0
to
e102a6d
Compare
|
e102a6d
to
abcd49d
Compare
It would still need to wait for that to make it into a release. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making all changes to a cask, verify:
brew audit --cask <cask>
is error-free.brew style --fix <cask>
reports no offenses.