Update ankama from 3.6.11 to 3.6.12

[miccal]

Created by brew bump

---

Created with brew bump-cask-pr.

[bevanjkay]

Can we keep this open for a little, we need to see why this isn't passing the audit.

[bevanjkay]

@samford
This one isn't passing audit at the moment and it seems to be relevant to https://github.com/Homebrew/brew/pull/11252/files

For whatever reason, only one of the responses has the set-cookie header and it is not present in the ones thereafter - so because we are only grabbing the responses.last it isn't seeing the set-cookie header.

{:status_code=>"503", :headers=>{"date"=>"Wed, 25 May 2022 06:47:58 GMT", "content-type"=>"text/html; charset=UTF-8", "x-frame-options"=>"SAMEORIGIN", "permissions-policy"=>"accelerometer=(),autoplay=(),camera=(),clipboard-read=(),clipboard-write=(),fullscreen=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()", "cache-control"=>"private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0", "expires"=>"Thu, 01 Jan 1970 00:00:01 GMT", "expect-ct"=>"max-age=604800, report-uri=\"https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct\"", "set-cookie"=>"__cf_bm=l1sumiUYyK2tIzIYLnsc_0fJhYZUjI10of1d3Ll3Xro-1653461278-0-AfVRwp85GOVJaWcPxcrg45+iSFMzAPPRfu8gvEQ6dy2/ZSdP413q8f5//ARoY4vEQSsXZTywc4EQjkjfwJhVfaY=; path=/; expires=Wed, 25-May-22 07:17:58 GMT; domain=.ankama.com; HttpOnly; Secure; SameSite=None", "server"=>"cloudflare", "cf-ray"=>"710c52a18e0ea86e-SYD"}}
{:status_code=>"503", :headers=>{"date"=>"Wed, 25 May 2022 06:48:00 GMT", "content-type"=>"text/html; charset=UTF-8", "x-frame-options"=>"SAMEORIGIN", "permissions-policy"=>"accelerometer=(),autoplay=(),camera=(),clipboard-read=(),clipboard-write=(),fullscreen=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()", "cache-control"=>"private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0", "expires"=>"Thu, 01 Jan 1970 00:00:01 GMT", "expect-ct"=>"max-age=604800, report-uri=\"https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct\"", "server"=>"cloudflare", "cf-ray"=>"710c52a88c17a86e-SYD"}}
{:status_code=>"503", :headers=>{"date"=>"Wed, 25 May 2022 06:48:02 GMT", "content-type"=>"text/html; charset=UTF-8", "x-frame-options"=>"SAMEORIGIN", "permissions-policy"=>"accelerometer=(),autoplay=(),camera=(),clipboard-read=(),clipboard-write=(),fullscreen=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()", "cache-control"=>"private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0", "expires"=>"Thu, 01 Jan 1970 00:00:01 GMT", "expect-ct"=>"max-age=604800, report-uri=\"https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct\"", "server"=>"cloudflare", "cf-ray"=>"710c52b6088da86e-SYD"}}
{:status_code=>"503", :headers=>{"date"=>"Wed, 25 May 2022 06:48:06 GMT", "content-type"=>"text/html; charset=UTF-8", "x-frame-options"=>"SAMEORIGIN", "permissions-policy"=>"accelerometer=(),autoplay=(),camera=(),clipboard-read=(),clipboard-write=(),fullscreen=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()", "cache-control"=>"private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0", "expires"=>"Thu, 01 Jan 1970 00:00:01 GMT", "expect-ct"=>"max-age=604800, report-uri=\"https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct\"", "server"=>"cloudflare", "cf-ray"=>"710c52d00ef3a86e-SYD"}}

I'm not sure if this is an upstream issue or if it is on our end.

[samford]

Thanks for the heads up. For what it's worth, this issue precedes Homebrew/brew#11252, as the previous code also used the headers from the final response (the current code just makes it more apparent). To be sure, I reinstated the previous #curl_http_content_headers_and_checksum logic and it predictably fails in the same fashion.

The values in the details return hash are expected to correspond to the final response, so I don't think we want to change that behavior. However, we could work around this by adding responses to the return hash and looping through them where we call #url_protected_by_cloudflare? (so we're not just checking the last response). I did a quick test and this approach works as expected. I'll have to rework some things but I'll create a brew PR once I'm done (edit: the PR with a fix can be found at Homebrew/brew#13326).

[samford]

@bevanjkay The Homebrew/brew fix has been merged and this is now passing after rerunning CI.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.

[bevanjkay]

Thanks for the fix @samford!