Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: avoid conflicts #147086

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented May 12, 2023

Closes #147085.

Avoid conflicts with hyperkit (which doesn't seem to be installed anymore) and kubectl and link all executables to /usr/local/bin.

@razvanazamfirei razvanazamfirei merged commit 849568d into Homebrew:master May 12, 2023
@reitermarkus reitermarkus deleted the docker-conflicts branch May 12, 2023 17:59
@danemacmillan
Copy link

danemacmillan commented May 12, 2023

@reitermarkus @razvanazamfirei

Just FYI, I uninstalled Docker Desktop an hour ago and then attempted to reinstall, and this suddenly no longer works. The errors are related to symlinks. It seems the symlinks are trying to be made directly into /usr/local/bin without actually prompting the user whether they should be made in the user's ${HOME} or with heightened privileges. Furthermore, these symlinks should not be getting made during the brew install docker --cask invocation, but upon opening the GUI and finalizing the install, which then creates symlinks.

I'm currently unable to install Docker Desktop via Homebrew, so unless this is localized to my environment, nor can anyone else.

[email protected] ~ $ brew install docker --cask
==> Downloading https://formulae.brew.sh/api/cask.jws.json
##O=- #      #
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-cask/b95671498dc538c4d95222a8636586c7f847c5a3/Casks/docker.rb
Already downloaded: /Users/danemacmillan/Library/Caches/Homebrew/downloads/94b16473c3601b98f3d8e73d0b4c76d9f4cfcfcc9e354958c867a1063d807c42--docker.rb
==> Downloading https://desktop.docker.com/mac/main/arm64/106363/Docker.dmg
Already downloaded: /Users/danemacmillan/Library/Caches/Homebrew/downloads/0f294fe5b9672995a9bff4404f68d9e27d9781b5f6f2959292b380a75781587d--Docker.dmg
==> Installing Cask docker
==> Moving App 'Docker.app' to '/Applications/Docker.app'
==> Linking Binary 'docker' to '/usr/local/bin/docker'
ln: /usr/local/bin/docker: Permission denied
==> Backing App 'Docker.app' up to '/opt/homebrew/Caskroom/docker/4.19.0,106363/Docker.app'
==> Removing App '/Applications/Docker.app'
==> Purging files for version 4.19.0,106363 of Cask docker
Error: Failure while executing; `/usr/bin/env /bin/ln -h -f -s -- /opt/homebrew/Caskroom/docker/4.19.0,106363/Docker.app/Contents/Resources/bin/docker /usr/local/bin/docker` exited with 1. Here's the output:
ln: /usr/local/bin/docker: Permission denied
Screenshot 2023-05-12 at 5 28 39 PM

razvanazamfirei added a commit that referenced this pull request May 12, 2023
reitermarkus added a commit that referenced this pull request May 13, 2023
miccal pushed a commit that referenced this pull request May 15, 2023
Revert "Revert "docker: avoid conflicts (#147086)" (#147103)"

This reverts commit aac68b8.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants