calhash, deeper, maintenance, onyx: use array for allowed macOS releases #154556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
EricFromCanada
force-pushed
the
calhash-move-depends_on
branch
from
8a20014 to
90cc30a
Compare
EricFromCanada
changed the title
bevanjkay
reviewed
Sep 8, 2023
Casks/c/calhash.rb
Outdated
| end | ||
|
|
||
| url "https://www.titanium-software.fr/download/#{MacOS.version.to_s.delete(".")}/CalHash.dmg" |
There was a problem hiding this comment.
@EricFromCanada Is MacOS.version now available when using SimulateSystem?
There was a problem hiding this comment.
MacOS.version always returns the actual OS version and ignores SimulateSystem completely right now.
There was a problem hiding this comment.
It was my understanding that we shouldn't be using MacOS.version anymore because it cannot be simulated where necessary now or in future. Which based on it still ignoring SimulateSystem we should probably keep the versions hard-coded in theon_{system} blocks for now.
p-linnane
previously approved these changes
Sep 8, 2023
EricFromCanada
force-pushed
the
calhash-move-depends_on
branch
from
90cc30a to
d18655d
Compare
EricFromCanada
force-pushed
the
calhash-move-depends_on
branch
from
d18655d to
3331856
Compare
miccal
approved these changes
Sep 9, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improved take on the issue addressed in #154503, relying on brew changes made in Homebrew/brew#15977. Applies the same changes to all apps from the same vendor, using syntax that wasn't originally available to define an exact list of allowed macOS releases. Each retains the Ventura block's
:or_newerto avoid issues with CI once macOS Sonoma testing starts, or oncebrew auditis updated to fully support SimulateSystem.