aerial@beta: update livecheck

[samford]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

The existing livecheck block for aerial@beta checks the releases page, searching for only pre-release releases and matching beta versions. This is an older livecheck block that hasn't been updated to use GithubReleases, so this updates it accordingly.

This also makes the beta suffix optional, so this will surface stable versions in addition to beta versions, like some other casks for unstable versions. Users can't have both the aerial and aerial@beta casks installed (since they conflict), so this ensures that users don't get stuck on an older unstable version when a newer stable version is available.

[khipp]

It makes sense that the cask should be able to update to the latest stable and pre-release versions. However, if I'm not mistaken, this currently results in an audit failure because the cask is whitelisted in audit_exceptions/github_prerelease_allowlist.json. Would it make sense to relax the audit in general, so that it only fails if casks not on the list are bumped to an unstable version?

[samford]

if I'm not mistaken, this currently results in an audit failure because the cask is whitelisted in audit_exceptions/github_prerelease_allowlist.json

Oh yeah, that's right. There was some previous discussion around this issue where some of us felt that the behavior of all was unexpected. all suggests to me that prerelease versions are allowed in addition to stable versions (which are already allowed by default) but that's not what it does.

If I remember correctly, a cask has to be removed from the allowlist if it's updated to a stable version, as it will fail the audit. To my understanding, this was intended as a way of ensuring that the cask is removed from the allowlist if it was only using unstable versions until a stable version was released. However, that doesn't work for casks that are created for unstable releases but can also update to a stable release (as here).

Unfortunately, we didn't end up with a consensus and that discussion/PR stalled. Just from my perspective, I think how all works should be updated to behave predictably (allowing both stable and prerelease versions) and the situation where a cask is using unstable versions until a stable version is released should be handled in a different way (I suggested a new until-stable allowlist value, which would work how all currently does, so the cask is removed from the allowlist when it's updated to a stable version).

This is something that we need to address but no one has picked up the torch yet (I have enough in-progress brew work that I'm trying to create PRs for 😆).