nvi: fix build with Xcode 12

Usual issue with -Wimplicit-function-declaration being an error by default now. Normal $CFLAGS fix doesn't quite work due to some flaws in the project's autoconf bits but this alternative works. Closes #66341. Signed-off-by: FX Coudert <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
Homebrew · Dec 6, 2020 · 7c7155a · 7c7155a
1 parent 1edf0d6
commit 7c7155a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/Formula/nvi.rb b/Formula/nvi.rb
@@ -51,9 +51,13 @@ class Nvi < Formula
 
   def install
     cd "dist" do
+      # Xcode 12 needs the "-Wno-implicit-function-declaration" to compile successfully
+      # The usual trick of setting $CFLAGS in the environment doesn't work for this
+      # configure file though, but specifying an explicit CC setting does
       system "./configure", "--prefix=#{prefix}",
                             "--program-prefix=n",
-                            "--disable-dependency-tracking"
+                            "--disable-dependency-tracking",
+                            "CC=" + ENV.cc + " -Wno-implicit-function-declaration"
       system "make"
       ENV.deparallelize
       system "make", "install"