Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: remove unneeded CFLAGS #106279

Closed
wants to merge 1 commit into from

Conversation

danielnachun
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@danielnachun danielnachun added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Jul 21, 2022
@danielnachun
Copy link
Contributor Author

Now that Homebrew/brew#13588 and Homebrew/brew#13568 are merged, we can drop the CFLAGS we were adding to fix the build.

@carlocab
Copy link
Member

Do we need new bottles for this?

@iMichka iMichka added the CI-no-bottles Merge without publishing bottles label Jul 21, 2022
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need new bottles; all of these changes are build time only.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@danielnachun danielnachun deleted the binutils branch July 21, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants