Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return of the linux bottles #107148

Closed
wants to merge 167 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Aug 2, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We now have a new strategy for handling the migration, which no longer requires the removal of bottles. See Homebrew/brew#13631.

Some of these bottles were lost due to changes from other PRs, but it looks like most of them should still be there.

I do still hope to get rid of all Linux-only GCC dependencies, but I think that's better done once we move to a new Ubuntu version.

@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 2, 2022
danielnachun
danielnachun previously approved these changes Aug 2, 2022
@danielnachun
Copy link
Contributor

This needs a quick rebase because another change to a bottle block has been merged. Once this is merged, I'll do a quick check of which formulae are missing Linux bottles that shouldn't be and dispatch new bottle builds for those.

@carlocab
Copy link
Member Author

carlocab commented Aug 2, 2022

This needs a quick rebase because another change to a bottle block has been merged. Once this is merged, I'll do a quick check of which formulae are missing Linux bottles that shouldn't be and dispatch new bottle builds for those.

Done

@carlocab carlocab requested a review from danielnachun August 2, 2022 19:15
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants