Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pillow: use Python's libexec/"bin" #107665

Closed
wants to merge 2 commits into from
Closed

pillow: use Python's libexec/"bin" #107665

wants to merge 2 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Aug 9, 2022

Needed for #107517.

@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Aug 9, 2022
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Aug 10, 2022
@carlocab
[email protected]: avoid shelling out to brew
b16d43a 
This breaks builds inside superenv. See
- Homebrew#107660
- Homebrew#107662
- Homebrew#107663
- Homebrew#107664
- Homebrew#107665
- pypa/distutils#155
- pypa/distutils#158
@carlocab carlocab mentioned this pull request Aug 10, 2022
Merged
6 tasks
carlocab added a commit that referenced this pull request Aug 10, 2022
@carlocab
[email protected]: avoid shelling out to brew (#107695)
9c31185 
This breaks builds inside superenv. See
- #107660
- #107662
- #107663
- #107664
- #107665
- pypa/distutils#155
- pypa/distutils#158
@carlocab carlocab mentioned this pull request Aug 10, 2022
Closed
6 tasks
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 11, 2022
@carlocab
Copy link
Member Author

It seems like this can't find any of the required libraries. Smells like a setuptools regression. CC @Bo98 @cho-m in case you have ideas here.

@cho-m
Copy link
Member

cho-m commented Aug 11, 2022 •
edited
Loading

Looks like 1 regression fix was merged in 63.4.0 for finding libraries: pypa/setuptools#3480. Sounds related. Probably worth trying build with a newer copy of setuptools >= 63.4.0.

@carlocab
Copy link
Member Author

carlocab commented Aug 11, 2022 •
edited
Loading

Looks like 1 regression fix was merged in 63.4.0 for finding libraries: pypa/setuptools#3480. Sounds related. Probably worth trying build with a newer copy of setuptools >= 63.4.0.

I plan to update to the latest setuptools and pip at #107517. We should probably just fix the Python references in the test in the meantime since we can't build this for now.

@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 11, 2022
@carlocab
Copy link
Member Author

Trying this as syntax-only for now to enable a merge, since we can't build this without updating setuptools.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Aug 11, 2022
@carlocab carlocab enabled auto-merge (squash) August 11, 2022 04:23
@carlocab carlocab disabled auto-merge August 11, 2022 04:34
@carlocab
Copy link
Member Author

Or, I suppose we can vendor setuptools here in the meantime.

@carlocab carlocab removed the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 11, 2022
@cho-m
Copy link
Member

cho-m commented Aug 11, 2022 •
edited
Loading

I don't mind either way. I think a newer setuptools with distutils fix will work and we can merge this as is.

Since issue seems to be in distutils, a workaround would be to use the stdlib copy (ENV["SETUPTOOLS_USE_DISTUTILS"] = "stdlib").

@carlocab
pillow: vendor setuptools
a94ebbf 
This works around a regression in the `setuptools` shipped with our
Python formulae.
@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 11, 2022
@carlocab
Copy link
Member Author

Using the latest setuptools seems to work.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @carlocab bottle publish failed.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the pillow branch September 17, 2022 15:51
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlocab @cho-m @BrewTestBot