Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krb5: disable gettext #109173

Merged
merged 1 commit into from
Aug 30, 2022
Merged

krb5: disable gettext #109173

merged 1 commit into from
Aug 30, 2022

Conversation

danielnachun
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@danielnachun danielnachun added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Aug 29, 2022
@danielnachun
Copy link
Contributor Author

Assuming krb5 does not actually link to gettext, this should pass the linkage audit with no issue.

Formula/krb5.rb Outdated
def install
cd "src" do
# Prevent opportunistic linking to gettext.
ENV["ac_cv_search_dgettext"] = "no"
Copy link
Member

@Bo98 Bo98 Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--disable-nls? Or is that not enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't see that. Let me see if stops the gettext check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants