-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binutils: remove texinfo dependency #109186
Conversation
7f9d86b
to
b321594
Compare
uses_from_macos "zlib" | ||
|
||
link_overwrite "bin/gold" | ||
link_overwrite "bin/ld.gold" | ||
link_overwrite "bin/dwp" | ||
|
||
def install | ||
# Workaround https://sourceware.org/bugzilla/show_bug.cgi?id=28909 | ||
touch "gas/doc/.dirstamp", mtime: Time.utc(2022, 1, 1) | ||
make_args = OS.mac? ? [] : ["MAKEINFO=true"] # for gprofng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How useful even is gprofng
? I'm a little keen on disabling it so we can also skip bison
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. Though at least bison
is lighter.
texinfo
dependency is indicative of a bug, since doc files should be pregenerated and we're not using autotools here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does bison
appear elsewhere in the Linux bootstrap dep tree? If not, we should just get rid of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not.
So I guess the concern here is that these dependencies drag in a large tree for build dependencies? I have no strong feelings either way given that |
Yeah, For the record: `brew deps --tree texinfo`
One of the reasons build deps always matter (besides bootstrapping from scratch etc.) is because of the non-x86_64 case. Which will get even more relevant if we're going to be using a newer GCC than what most people have. |
Does |
Could be. Haven't had a proper look at that. |
The
texinfo
dependency tree is far too large for a critical component of Homebrew on older Linuxes.It brings in the entire Python dependency tree and greatly increases the risk of including C++-only dependencies, which themselves require a modern GCC.
The dependency should also be completely unnecessary, but upstream's tarball is bugged.