Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpytop: fix test for arm #121636

Closed
wants to merge 1 commit into from
Closed

Conversation

branchvincent
Copy link
Member

@branchvincent branchvincent commented Jan 27, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

For #114154

Since at least last month, this test fails on arm: #117510 (comment) (interestingly, the second error no longer occurs). Looks like psutil.cpu_freq() has never worked on arm, so not sure how this passed before: giampaolo/psutil#1892. Since this is a non-fatal error and bpytop still functions, just ignore disable showing cpu frequency.

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jan 27, 2023
@branchvincent branchvincent force-pushed the bpytop branch 2 times, most recently from f2659cb to 6a26daf Compare January 27, 2023 06:16
@branchvincent branchvincent added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 27, 2023
@carlocab
Copy link
Member

Fails on Monterey with

27/01/23 (03:44:36) | INFO: New instance of bpytop version 1.0.68 started with pid 8078
27/01/23 (03:44:36) | INFO: Loglevel set to DEBUG
27/01/23 (03:44:36) | DEBUG: Using psutil version 5.9.3
27/01/23 (03:44:36) | DEBUG: CMD: /opt/homebrew/Cellar/bpytop/1.0.68/bin/bpytop
27/01/23 (03:44:36) | ERROR: could not convert string to float: 'Error: no SMC found\n0.0'
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/bpytop/1.0.68/bin/bpytop", line 3228, in _collect_temps
    temp = max(0, round(float(subprocess.check_output("osx-cpu-temp", universal_newlines=True).strip()[:-2])))
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: 'Error: no SMC found\n0.0'
27/01/23 (03:44:36) | DEBUG: Collect and draw completed in 0.254984 seconds

@chenrui333
Copy link
Member

build/test out fine in my local before rebase (ventura arm), let's give it another spin.

@cho-m
Copy link
Member

cho-m commented Jan 30, 2023

I remember seeing bpytop test failing with SMC not found error in another PR. I guess it is due to ephemeral ARM CI environment given it only happens on ARM Ventura, but would need someone more familiar with runners to look into.

I doubt it would occur on a physical machine, but we could try upstreaming a way to hide the error message. osx-cpu-temp prints message to stdout (https://github.com/lavoiesl/osx-cpu-temp/blob/1.1.0/smc.c#L71) so could grab last line.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 20, 2023
@github-actions github-actions bot closed this Feb 27, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
@branchvincent branchvincent deleted the bpytop branch November 13, 2023 02:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age python Python use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants