opensearch-dashboards 2.8.0

[p-linnane]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[SMillerDev]

  ../src/ordered-binary.cpp: In function ‘size_t valueToKey(const v8::Local<v8::Value>&, uint8_t*, size_t, bool, bool)’:
  ../src/ordered-binary.cpp:138:91: error: no matching function for call to ‘v8::Symbol::Description()’
    138 |         Local<String> string = Local<String>::Cast(Local<Symbol>::Cast(jsKey)->Description());
        |                                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
  In file included from /tmp/opensearch-dashboards-20230621-11980-128x95i/.brew_home/.cache/node-gyp/18.16.0/include/node/v8-object.h:11,
                   from /tmp/opensearch-dashboards-20230621-11980-128x95i/.brew_home/.cache/node-gyp/18.16.0/include/node/v8-array-buffer.h:13,
                   from /tmp/opensearch-dashboards-20230621-11980-128x95i/.brew_home/.cache/node-gyp/18.16.0/include/node/v8.h:24,
                   from ../src/node-lmdb.h:29,
                   from ../src/ordered-binary.cpp:1:
  /tmp/opensearch-dashboards-20230621-11980-128x95i/.brew_home/.cache/node-gyp/18.16.0/include/node/v8-primitive.h:588:16: note: candidate: ‘v8::Local<v8::Value> v8::Symbol::Description(v8::Isolate*) const’
    588 |   Local<Value> Description(Isolate* isolate) const;
        |                ^~~~~~~~~~~
  /tmp/opensearch-dashboards-20230621-11980-128x95i/.brew_home/.cache/node-gyp/18.16.0/include/node/v8-primitive.h:588:16: note:   candidate expects 1 argument, 0 provided

[cho-m]

Upstream issue: opensearch-project/OpenSearch-Dashboards#4260. Could try patching with backport fix commit.

[cho-m]

New failure is:

   info [  opensearch-dashboards  ] Creating platform-specific archive source directories
     │ debg Generic build source copied into linux-x64 specific build directory
     │ERROR failure 3 sec
     │ERROR Error: ENOENT: no such file or directory, scandir '/tmp/opensearch-dashboards-20230624-6480-miftn0/.node_binaries/14.21.3/linux-x64'

Maybe happening during https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.8.0/src/dev/build/tasks/create_archives_sources_task.ts#L57-L69

Our formula comments out the prior scanCopy and other NodeJS downloads, which is probably causing issues in this new download logic.