Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gismo: move to g shard #141362

Merged
merged 1 commit into from
Sep 4, 2023
Merged

gismo: move to g shard #141362

merged 1 commit into from
Sep 4, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Sep 4, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

git mv Formula/gismo.rb Formula/g/gismo.rb

I'm working on adding an audit for this.

@bayandin bayandin added the CI-no-bottles Merge without publishing bottles label Sep 4, 2023
@bayandin bayandin mentioned this pull request Sep 4, 2023
Merged
7 tasks
@bayandin bayandin added CI-no-bottles Merge without publishing bottles and removed CI-no-bottles Merge without publishing bottles labels Sep 4, 2023
@bayandin
Copy link
Member Author

bayandin commented Sep 4, 2023 

brew install --only-dependencies --include-test gismo
==> FAILED
Full install --only-dependencies --include-test gismo output
  ==> Downloading https://ghcr.io/v2/homebrew/core/gismo/manifests/21.12.0
  Already downloaded: /Users/brew/Library/Caches/Homebrew/downloads/b36bee2faf5aa2c506f570830307e9f0d52271faeaeda3d22ec6d6c1d0cd4776--gismo-21.12.0.bottle_manifest.json
  ==> Downloading https://ghcr.io/v2/homebrew/core/gismo/manifests/21.12.0
  Error: Couldn't find manifest matching bottle checksum.
  Do not report this issue until you've run `brew update` and tried again.
  /opt/homebrew/Library/Homebrew/software_spec.rb:[44](https://github.com/Homebrew/homebrew-core/actions/runs/6073163833/job/16478068923?pr=141362#step:3:45)1:in `github_packages_manifest_resource_tab'
  /opt/homebrew/Library/Homebrew/software_spec.rb:394:in `fetch_tab'
  /opt/homebrew/Library/Homebrew/formula.rb:2822:in `fetch_bottle_tab'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10[46](https://github.com/Homebrew/homebrew-core/actions/runs/6073163833/job/16478068923?pr=141362#step:3:47)1/lib/types/private/methods/call_validation.rb:157:in `call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
  /opt/homebrew/Library/Homebrew/formula_installer.rb:1210:in `fetch_bottle_tab'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
  /opt/homebrew/Library/Homebrew/formula_installer.rb:524:in `compute_dependencies'
  /opt/homebrew/Library/Homebrew/formula_installer.rb:233:in `verify_deps_exist'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
  /opt/homebrew/Library/Homebrew/formula_installer.rb:223:in `prelude'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/call_validation.rb:157:in `validate_call'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10461/lib/types/private/methods/_methods.rb:270:in `block in _on_method_added'
  /opt/homebrew/Library/Homebrew/install.rb:276:in `block in install_formulae'
  /opt/homebrew/Library/Homebrew/install.rb:2[47](https://github.com/Homebrew/homebrew-core/actions/runs/6073163833/job/16478068923?pr=141362#step:3:48):in `map'
  /opt/homebrew/Library/Homebrew/install.rb:247:in `install_formulae'
  /opt/homebrew/Library/Homebrew/cmd/install.rb:295:in `install'
  /opt/homebrew/Library/Homebrew/brew.rb:94:in `<main>'

@MikeMcQuaid MikeMcQuaid mentioned this pull request Sep 4, 2023
Merged
@MikeMcQuaid
Copy link
Member

@bayandin whoops, my bad, should be fixed by Homebrew/brew#15949

@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 4, 2023
Merged via the queue into Homebrew:master with commit fdbb084 Sep 4, 2023
@bayandin bayandin deleted the gismo-fix-path branch September 4, 2023 17:47
dduugg pushed a commit to dduugg/brew that referenced this pull request Sep 30, 2023
@MikeMcQuaid @dduugg
formula_installer: handle another exception in fetch_bottle_tab.
1059973 
Fix another way that fetching a bottle tab can fail. This pretty much
only happens in CI.

Addresses Homebrew/homebrew-core#141362 (comment)
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bayandin @MikeMcQuaid @SMillerDev @BrewTestBot