zls: use ReleaseSafe instead of ReleaseFast

[chenrui333]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

• fast-release - slow compilation, fully optimized runtime performance, safety checks off
• safe-release - slow compilation, fully optimized runtime performance, safety checks on

relates to ziglang/zig#288

[carlocab]

Seems nicer to keep ReleaseFast unless users report problems with it.

[SMillerDev]

relates to ziglang/zig#288

That's from 7 years ago with no relevance to Homebrew though. What are we doing this for?

[chenrui333]

relates to ziglang/zig#288

That's from 7 years ago with no relevance to Homebrew though. What are we doing this for?

Oh, that is just saying the fact this option has been existing for quite some time.

this might be a better diagram from ziglang/zig#978

[chenrui333]

also upstream is using releasesafe for their release builds though.

• https://github.com/zigtools/zls/blob/master/README.md?plain=1#L36
• https://github.com/zigtools/zls/blob/f726e9e6c9a3fc016e67e4b18e33443e7d562704/flake.nix#L44
• https://github.com/zigtools/zls/blob/f726e9e6c9a3fc016e67e4b18e33443e7d562704/.github/workflows/main.yml#L66

[SMillerDev]

Is it also the default?

[chenrui333]

Is it also the default?

right now it is not the default in the build.zig

[chenrui333]

I think one of the reasons is that std.builtin.Mode is not just for release build but also debug build.

[carlocab]

Is it also the default?

The default is always debug, IIUC.

[chenrui333]

gonna close it for now, we can revisit it later.