Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy3.9 7.3.16 #164607

Merged
merged 2 commits into from
Apr 26, 2024
Merged

pypy3.9 7.3.16 #164607

merged 2 commits into from
Apr 26, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 29, 2024
@cho-m cho-m mentioned this pull request Feb 29, 2024
Merged
@cho-m cho-m added the checksum mismatch SHA-256 doesn't match the download label Feb 29, 2024
@p-linnane p-linnane added the upstream issue An upstream issue report is needed label Mar 1, 2024
@p-linnane
Copy link
Member

Opened an upstream issue re: the checksums: pypy/pypy#4919

@p-linnane p-linnane added in progress Stale bot should stay away CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed upstream issue An upstream issue report is needed automerge-skip `brew pr-automerge` will skip this pull request labels Mar 1, 2024
@p-linnane
Copy link
Member

Upstream confirmed that the files were modified a few hours after release.

@p-linnane p-linnane force-pushed the pypy-resources-autoupdate branch from e6b7300 to b07d588 Compare March 2, 2024 17:26
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 2, 2024
@p-linnane p-linnane force-pushed the pypy-resources-autoupdate branch from b07d588 to b0085ff Compare March 2, 2024 17:37
@p-linnane
Copy link
Member

Tests need to be updated and we need a long build as well.

@p-linnane p-linnane added the long build Set a long timeout for formula testing label Mar 2, 2024
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 4, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 4, 2024
@cho-m cho-m force-pushed the pypy-resources-autoupdate branch from b0085ff to 2039e51 Compare March 13, 2024 23:49
@cho-m cho-m changed the title pypy3.9 pypy3.10: run brew update-python-resources pypy3.9: update resources and workaround to enable new setuptools Mar 13, 2024
@cho-m cho-m force-pushed the pypy-resources-autoupdate branch from 2039e51 to fe84f1a Compare March 13, 2024 23:52
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 14, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 14, 2024
@cho-m cho-m added build failure CI fails while building the software linux Linux is specifically affected labels Mar 14, 2024
@cho-m
Copy link
Member Author

cho-m commented Mar 14, 2024

Focusing on pypy3.9 for now.

Added a different workaround to get new setuptools rather than creating another patch as I think the patch modifications are to allow dependent usage inside Homebrew. Quick local tests worked.

No idea yet on Linux failure. Looks like the build was successful but something is going wrong afterward, maybe in brew:

2024-03-14T03:14:42.7706256Z * Binaries: ['pypy/goal/pypy3.9-c', 'pypy/goal/libpypy3.9-c.so']
2024-03-14T03:14:42.7706857Z Copying /tmp/pypy3.9-20240314-6015-k03281/pypy3.9-v7.3.15-src/usession-release-pypy3.9-v7.3.15-1/build/pypy3.tar.bz2 to .
2024-03-14T03:14:42.7707317Z Ready in /tmp/pypy3.9-20240314-6015-k03281/pypy3.9-v7.3.15-src/usession-release-pypy3.9-v7.3.15-1/build
2024-03-14T03:14:42.7707829Z ==> tar -C /home/linuxbrew/.linuxbrew/Cellar/pypy3.9/7.3.15/libexec --strip-components 1 -xf pypy3.tar.bz2
2024-03-14T03:14:42.7708069Z Error: An exception occurred within a child process:
2024-03-14T03:14:42.7708298Z   NoMethodError: undefined method `header' for nil:NilClass

@cho-m cho-m force-pushed the pypy-resources-autoupdate branch from fe84f1a to 70930f2 Compare March 24, 2024 16:39
@cho-m cho-m added CI-checksum-change-confirmed A checksum change was confirmed by upstream and removed build failure CI fails while building the software automerge-skip `brew pr-automerge` will skip this pull request labels Mar 24, 2024
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 26, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 26, 2024
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed ready to merge PR can be merged once CI is green labels Mar 26, 2024
cho-m
cho-m commented Mar 26, 2024
View reviewed changes
@cho-m cho-m force-pushed the pypy-resources-autoupdate branch from 4abaa2b to 89a69ac Compare March 26, 2024 17:15
@chenrui333
Copy link
Member

there is a new release now 7.3.16

@cho-m cho-m mentioned this pull request Apr 24, 2024
Closed
1 task
@cho-m
pypy3.9 7.3.16
29ca567 
pypi_formula_mappings: add `pypy3.9` extra_packages

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m force-pushed the pypy-resources-autoupdate branch from 89a69ac to 29ca567 Compare April 26, 2024 02:08
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed checksum mismatch SHA-256 doesn't match the download automerge-skip `brew pr-automerge` will skip this pull request CI-checksum-change-confirmed A checksum change was confirmed by upstream labels Apr 26, 2024
@cho-m cho-m changed the title pypy3.9: update resources and workaround to enable new setuptools pypy3.9 7.3.16 Apr 26, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 26, 2024
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed long build Set a long timeout for formula testing labels Apr 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 26, 2024
@BrewTestBot BrewTestBot enabled auto-merge April 26, 2024 21:13
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit 76a49f9 Apr 26, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the pypy-resources-autoupdate branch April 26, 2024 21:22
@github-actions github-actions bot added the outdated PR was locked due to age label May 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@iMichka iMichka iMichka approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cho-m @p-linnane @chenrui333 @iMichka @BrewTestBot