-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batt 0.2.1 (new formula) #166340
batt 0.2.1 (new formula) #166340
Conversation
d94922b
to
bad2471
Compare
cdce86f
to
e99fe6a
Compare
I think that's about it, a Formula with a sane test. Sort of. No idea why the
|
I think it can be removed because the ipc http client is contained in the binary itself. |
e99fe6a
to
0011034
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The failing test should have been resolved by Homebrew/brew#16914, a relatively new change. Now the tests should not be failing anymore. |
@Jerry1144 can you rebase your pr to the latest master and give it a rerun? Thanks! |
0011034
to
e1310f5
Compare
Add [batt], a tool to manipulate charging limit on Apple Silicon Macbooks in place of macOS's opaque Optimize Battry settings. A service do block was also supplied to utilize brew services. [batt]:https://github.com/charlie0129/batt
e1310f5
to
509ba7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work @Jerry1144!
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Add batt, a utility to manually control charging of Apple Silicon Macbooks, instead of hoping macOS limit charging to 80% for us. I tried to use
brew services
to handle installing the relevant launchd.plist, although the tool itself has a built-in routine to do so.I wonder if, instead of hardcoding them,
there's a more elegant way of fetching. Having Ruby variables holding these two means we don't forget about those in theVERSION
andGIT_COMMIT
variables from the URLtest do
block below.I cannot decide whether to use
system "plutil"
orinreplace
to modify the plist file, too. The former won't work on Linux, but it handles insertion better than the inflexible replacement syntax.Theuses_from_macos "curl"
documents the peculiar fact that IPC is handled using http. Should I remove it instead?