Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glew: declare indirect deps with linkage #177962

Merged
merged 1 commit into from
Aug 5, 2024
Merged

glew: declare indirect deps with linkage #177962

merged 1 commit into from
Aug 5, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

https://github.com/Homebrew/homebrew-core/actions/runs/9993807198/job/27630461929

@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Jul 21, 2024

This comment was marked as resolved.

@chenrui333
Copy link
Member Author

  [100%] Built target glew_s
  Undefined symbols for architecture arm64:
    "_CGLChoosePixelFormat", referenced from:
        _glewCreateContext in glewinfo.c.o
    "_CGLCreateContext", referenced from:
        _glewCreateContext in glewinfo.c.o
    "_CGLReleaseContext", referenced from:
        _main in glewinfo.c.o
        _main in glewinfo.c.o
        _main in glewinfo.c.o
        _glewDestroyContext in glewinfo.c.o
    "_CGLReleasePixelFormat", referenced from:
        _glewCreateContext in glewinfo.c.o
  ld: symbol(s) not found for architecture arm64

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 21, 2024
glew: fix build with newer CMake

Co-authored-by: Michael Cho <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. and removed build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 1, 2024
@chenrui333
Copy link
Member Author

@chenrui333 chenrui333 added this pull request to the merge queue Aug 5, 2024
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-no-bottles Merge without publishing bottles labels Aug 5, 2024
Merged via the queue into master with commit 3bb3fee Aug 5, 2024
33 of 37 checks passed
@chenrui333 chenrui333 deleted the glew-linkage branch August 5, 2024 21:28
@chenrui333 chenrui333 added CI-no-bottles Merge without publishing bottles and removed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants