Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blisp 0.0.4 (new formula) #192901

Merged
merged 2 commits into from
Oct 8, 2024
Merged

blisp 0.0.4 (new formula) #192901

merged 2 commits into from
Oct 8, 2024

Conversation

altf4arnold
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

it fails when asking the version to the package. because the package doesn't have that flag

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@carlocab carlocab changed the title [ADD] Adding BLISP blisp 0.0.4 (new formula) Oct 5, 2024
@altf4arnold
Copy link
Contributor Author

I don't get what I'm doing wrong in the regard to the commit message

carlocab
carlocab reviewed Oct 5, 2024
View reviewed changes
Formula/b/blisp.rb Outdated Show resolved Hide resolved
Formula/b/blisp.rb Outdated Show resolved Hide resolved
Formula/b/blisp.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 5, 2024
carlocab
carlocab reviewed Oct 5, 2024
View reviewed changes
Formula/b/blisp.rb Outdated Show resolved Hide resolved
carlocab
carlocab reviewed Oct 5, 2024
View reviewed changes
Formula/b/blisp.rb Outdated Show resolved Hide resolved
@altf4arnold altf4arnold force-pushed the blisp branch 2 times, most recently from 9a98512 to a05f7e7 Compare October 5, 2024 17:39
@altf4arnold
Copy link
Contributor Author

I don't get why the tests are failing

@chenrui333
Copy link
Member

audit failure for installation

  blisp
    * Non-libraries were installed to "/home/linuxbrew/.linuxbrew/opt/blisp/lib".
      Installing non-libraries to "lib" is discouraged.
      The offending files are:
        /home/linuxbrew/.linuxbrew/opt/blisp/lib/blisp_chip.h
        /home/linuxbrew/.linuxbrew/opt/blisp/lib/blisp_util.h
        /home/linuxbrew/.linuxbrew/opt/blisp/lib/blisp.h
        /home/linuxbrew/.linuxbrew/opt/blisp/lib/blisp_struct.h
        /home/linuxbrew/.linuxbrew/opt/blisp/lib/blisp_easy.h

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 6, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 6, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 6, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 6, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 6, 2024
chenrui333
chenrui333 reviewed Oct 6, 2024
View reviewed changes
Formula/b/blisp.rb Outdated Show resolved Hide resolved
@altf4arnold
Copy link
Contributor Author

Yay \o/

chenrui333
chenrui333 reviewed Oct 6, 2024
View reviewed changes
Formula/b/blisp.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Oct 6, 2024
View reviewed changes
Formula/b/blisp.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 mentioned this pull request Oct 6, 2024
Open
@altf4arnold @chenrui333
blisp 0.0.4
1aad4b7 
This software allows for flashing of RISC-V microcontrollers and SOC's.
The software is relatively basic and documented as part of flashing procedures on the pine64 wiki (pinecil)

blisp: update build and test and autobump

Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Oct 6, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 6, 2024
altf4arnold
altf4arnold commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@altf4arnold altf4arnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I forgot that

@altf4arnold altf4arnold requested a review from carlocab October 7, 2024 13:04
@chenrui333
Copy link
Member

@altf4arnold thanks for your first contribution to homebrew-core! 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 8, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 8, 2024 12:07
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 8, 2024
Merged via the queue into Homebrew:master with commit e791411 Oct 8, 2024
15 checks passed
@altf4arnold altf4arnold deleted the blisp branch October 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab Awaiting requested review from carlocab

Assignees
No one assigned
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altf4arnold @chenrui333 @carlocab @BrewTestBot