-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-component-ld 0.5.10 (new formula), wasi-runtimes: depend on wasm-component-ld
#195828
Conversation
I think there is a vendored copy in Rust and a wrapper around it https://github.com/rust-lang/rust/tree/1.82.0/src/tools/wasm-component-ld. It is currently built, but haven't checked if this was intended, e.g. ❯ fd wasm-component-ld /opt/homebrew/opt/rust/
/opt/homebrew/opt/rust/lib/rustlib/aarch64-apple-darwin/bin/wasm-component-ld
❯ /opt/homebrew/opt/rust/lib/rustlib/aarch64-apple-darwin/bin/wasm-component-ld --version
wasm-component-ld 0.5.7 |
Yep, I found that, but after testing it (for |
Having a separate formula is also fine. I also wasn't sure if Rust was supposed to include the |
394f31e
to
a0f2e89
Compare
a0f2e89
to
3ac89c5
Compare
c3f6e38
to
75b439d
Compare
This is needed to enable the `rust` formula to target WASI, and will enable us to remove existing uses of `rustup` at build-time.
This doesn't detect the features of our toolchain correctly without it.
75b439d
to
52fbd98
Compare
wasm-component-ld
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This is needed to enable the
rust
formula to target WASI, and willenable us to remove existing uses of
rustup
at build-time.brew audit --new
fails because of the notability check, but I think wecan/should make an exception for this.