Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_renames: remove old recursive renames #197182

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 9, 2024

  • gtef -> tepl was from 2017-09-10. Renamed to libgedit-tepl
  • latexila -> gnome-latex was from 2018-05-16. Renamed to enter-tex

Deciding on whether to audit recursive renames in Homebrew/brew#18741 as it simplifies logic.

The idea for handling these is old renames that require recursive resolution can be dropped while newer renames can be squashed/flattened to avoid recursive handling

There is also a separate discussion on always dropping old renames and replacing some with aliases if the old name is common/popular enough.

* `gtef -> tepl` was from 2017-09-10. Renamed to `libgedit-tepl`
* `latexila -> gnome-latex` was from 2018-05-16. Renamed to `enter-tex`
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 9, 2024
@cho-m
Copy link
Member Author

cho-m commented Nov 9, 2024

Draft to keep CI failures in Homebrew/brew#18741 to test audit works.

@cho-m cho-m marked this pull request as ready for review November 11, 2024 13:47
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Nov 11, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 1b2e4be Nov 11, 2024
20 checks passed
@BrewTestBot BrewTestBot deleted the formula_renames-remove-recursive branch November 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants