Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bilix: remove livecheck #200430

Merged
merged 1 commit into from
Dec 8, 2024
Merged

bilix: remove livecheck #200430

merged 1 commit into from
Dec 8, 2024

Conversation

samford
Copy link
Member

@samford samford commented Dec 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The current bilix livecheck block was recently added because livecheck was using the Pypi strategy by default but it was failing because of upstream changes. We've made changes to the Pypi strategy to work around the issue, so this removes the livecheck block to ensure that livecheck will use the Pypi for this formula again.

Related to Homebrew/brew#18895

The current `bilix` `livecheck` block was recently added because
livecheck was using the `Pypi` strategy by default but it was failing
because of upstream changes. We've made changes to the `Pypi` strategy
to work around the issue, so this removes the `livecheck` block to
ensure that livecheck will use the `Pypi` for this formula again.
@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Dec 8, 2024
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Dec 8, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Dec 8, 2024
@chenrui333
Copy link
Member

Thanks @samford!

Merged via the queue into master with commit 1df3fdd Dec 8, 2024
18 checks passed
@chenrui333 chenrui333 deleted the bilix-remove-livecheck branch December 8, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants