-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homeworlds: update stable url #205524
base: master
Are you sure you want to change the base?
homeworlds: update stable url #205524
Conversation
|
What other formula are doing this? The warning in the homebrew-core/Formula/l/luajit.rb Lines 1 to 5 in dde579e
|
The ones I'm updating are four old formulae that have been using a specific commit with no tag since they were introduced (I found them while collecting statistics on github.com URLs):
The comment in In terms of existing formulae using a commit tarball, there are two more old formulae but also one that was introduced in 2024:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks OK to me per se since we are already using the commit so it doesn't worsen the situation. However I do think that we should deprecate this formula since it doesn't really meet our standards (and is not popular either). (Same for the other formulae mentioned in #205524 (comment) unless there's a reason not to.)
The existing `stable` URL for `homeworlds` is a Git revision with no `tag`. We have some other formulae in a similar situation but they use a commit tarball instead of checking out the Git repository (e.g., `luajit`), so this updates the formula to follow the same pattern. This also deprecates the formula, as the `stable` URL does not meet our current requirements.
166da42
to
9b23362
Compare
Works for me. I've updated this to deprecate the formula. I'm planning to open an upstream issue for I can handle the deprecation for |
# Unversioned and upstream repository has no tags or releases. | ||
deprecate! date: "2025-01-26", because: "does not meet requirements for `stable` URLs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ask upstream if they're willing to cut a release tag before deprecating this?
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?The existing
stable
URL forhomeworlds
is a Git revision with notag
. We have some other formulae in a similar situation but they use a commit tarball instead of checking out the Git repository (e.g.,luajit
), so this updates the formula to follow the same pattern.