Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homeworlds: update stable url #205524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

samford
Copy link
Member

@samford samford commented Jan 26, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The existing stable URL for homeworlds is a Git revision with no tag. We have some other formulae in a similar situation but they use a commit tarball instead of checking out the Git repository (e.g., luajit), so this updates the formula to follow the same pattern.

p-linnane
p-linnane previously approved these changes Jan 26, 2025
@p-linnane p-linnane dismissed their stale review January 26, 2025 02:20

Misread comment

Copy link
Contributor

⚠️ Pre-merge checks failed.

@p-linnane
Copy link
Member

What other formula are doing this? The warning in the luajit formula sounds like we should not do this.

# NOTE: We have a policy of building only from tagged commits, but make a
# singular exception for luajit. This exception will not be extended
# to other formulae. See:
# https://github.com/Homebrew/homebrew-core/pull/99580
# TODO: Add an audit in `brew` for this. https://github.com/Homebrew/homebrew-core/pull/104765

@samford
Copy link
Member Author

samford commented Jan 26, 2025

What other formula are doing this?

The ones I'm updating are four old formulae that have been using a specific commit with no tag since they were introduced (I found them while collecting statistics on github.com URLs):

The comment in luajit is correct but these were added years earlier and we can't use a tag in these cases. I've been updating these to use a commit tarball, as we only use Git when there's a technical need and that doesn't appear to be the case for these (they're just holdovers from years past).

In terms of existing formulae using a commit tarball, there are two more old formulae but also one that was introduced in 2024:

  • runcocoa: Formula disabled, unversioned, no tags or releases; added on 2011-04-28 in 2414f22
  • solid: No tags or releases; added on 2011-09-23 in New Formula: solid legacy-homebrew#7776
  • wasi-libc: Formula uses commit hash of the wasi-libc submodule in wasi-sdk repository for a given tag, and that may not always correspond to a wasi-libc tag (it does right now, though); added on 2024-10-22 in wasi-libc 24 (new formula) #195222

@p-linnane p-linnane requested a review from a team January 26, 2025 18:31
@p-linnane p-linnane added the maintainer feedback Additional maintainers' opinions may be needed label Jan 26, 2025
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK to me per se since we are already using the commit so it doesn't worsen the situation. However I do think that we should deprecate this formula since it doesn't really meet our standards (and is not popular either). (Same for the other formulae mentioned in #205524 (comment) unless there's a reason not to.)

The existing `stable` URL for `homeworlds` is a Git revision with no
`tag`. We have some other formulae in a similar situation but they
use a commit tarball instead of checking out the Git repository
(e.g., `luajit`), so this updates the formula to follow the same
pattern.

This also deprecates the formula, as the `stable` URL does not meet
our current requirements.
@samford samford force-pushed the homeworlds-update-stable-url branch from 166da42 to 9b23362 Compare January 27, 2025 01:51
@github-actions github-actions bot added the formula deprecated Formula deprecated label Jan 27, 2025
@samford
Copy link
Member Author

samford commented Jan 27, 2025

Works for me. I've updated this to deprecate the formula.

I'm planning to open an upstream issue for colortail, to see if they will tag 0.3.4. A former Homebrew maintainer asked them to tag releases (ten years ago) and they tagged 0.3.3 but didn't go on to tag 0.3.4. It seems like they may be receptive if we ask again and that would allow us to switch the formula to a tag tarball instead of deprecating it.

I can handle the deprecation for pip-completion in the upcoming PR to update the stable URL. I'll create PRs for the others (outside of colortail and wasi-libc) afterward.

Comment on lines +28 to +29
# Unversioned and upstream repository has no tags or releases.
deprecate! date: "2025-01-26", because: "does not meet requirements for `stable` URLs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ask upstream if they're willing to cut a release tag before deprecating this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formula deprecated Formula deprecated maintainer feedback Additional maintainers' opinions may be needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants