-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3 3.5.2 #2415
python3 3.5.2 #2415
Conversation
These tools should also be upgraded within this pull request: * pip-8.1.2 * setuptools-23.1.0 * wheel-0.29.0
The patch that is failing to apply is no longer required. It was applied upstream (the only difference between the patch in this formula and the upstream commit is that the upstream commit also added some comments explaining it). The formula seems to build fine for me by removing that patch. |
The patch that is failing to apply is no longer required. It was [applied upstream](python/cpython@6e0963c) (the only difference between the [patch in this formula](https://bugs.python.org/file40478/xcode-stubs.diff) and the upstream commit is that the upstream commit also added some comments explaining it). The formula seems to build fine for me by removing that patch.
Looks good once the patch is removed. I'll plan to squash these into a single commit with the title |
Hi Tim, If you could do that, it would be great. My git skills are pretty weak. |
Sure thing. Please go ahead and push another commit to this branch removing the patch. Thanks! |
could you update devel block with the latest alpha release, devel do
url "https://www.python.org/ftp/python/3.6.0/Python-3.6.0a2.tar.xz"
sha256 "2dd2ddf22a63ef9642a20b1f5a40983209e8d7a8ad8371a881fde520edc9ff86"
end |
I'll do that on pull; thanks for noticing the new alpha release. |
I'm not sure those URLs for setuptools and wheel are correct; can you verify? |
I believe they're wrong. I have a fixed patch that passes tests on cclauss/homebrew-core#1, if @cclauss just merges it, everything should be fine. |
Remove unneeded patch from Python-3.5.2 formula.
FYI: You can use new URL for packages:
where:
From what I heard, this is how it will work from now on. There are cons and pros for this. Pros:
Cons:
|
FWIW, pypi doesn't allow files to be replaced, so this shouldn't be a concern. |
Oops! This is blocking on an issue with our new MachO support; ping @woodruffw. See http://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/3886/version=yosemite/testReport/junit/brew-test-bot/yosemite/bottle_python3/ |
confirm fixed by Homebrew/brew#400 |
In the meantime Python 2.7.12 was released https://www.python.org/downloads/release/python-2712/. See: PR #2452 |
Sorry for the build chaos over here 🙇 |
@woodruffw Is the test failing above a problem for this PR on not? |
@cclauss Not anymore, only earlier. |
@woodruffw Your meaning of your response is not clear to me. The formula works on my Mac but the test above is failing. Does the test failure above (on PyQT5 ??) mean that there is a problem with this PR? |
@cclauss Sorry for the confusion. A commit not related to your formula (Homebrew/brew/pull/400) was merged prematurely, causing your build failure. That commit was reverted, and I've restarted your build on the CI. There's nothing wrong with your PR AFAICT. |
To extend @woodruffw's remarks: we need some version of Homebrew/brew#400 to land before this PR will succeed, so this won't pass just yet, but the PR itself is still fine. |
Restarted the build after Homebrew/brew#400 had landed and looks like the bug has been properly resolved this time. I guess this PR can be merged if @tdsmith is happy with this. |
Thanks for your patience, everyone! |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?https://www.python.org/downloads/release/python-352/ Also upgrades
setuptools
,pip
, andwheel
Fails when applying Homebrew/python3--patch