Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal: always install pkg-config #35443

Closed
wants to merge 1 commit into from

Conversation

zegl
Copy link
Contributor

@zegl zegl commented Dec 25, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

pkg-config seems to always be required to compile Crystal programs,
see crystal-lang/crystal#6875

pkg-config seems to always be required to compile Crystal programs,
see crystal-lang/crystal#6875
@igas
Copy link
Contributor

igas commented Dec 26, 2018

Error Message
failed: brew audit crystal --online
Stacktrace
        Error: 6 problems in 1 formula detected
crystal:
  * C: 31: col 3: dependency "bdw-gc" (line 31) should be put before dependency "pkg-config" (line 30)
  * C: 32: col 3: dependency "gmp" (line 32) should be put before dependency "pkg-config" (line 30)
  * C: 33: col 3: dependency "libevent" (line 33) should be put before dependency "pkg-config" (line 30)
  * C: 34: col 3: dependency "libyaml" (line 34) should be put before dependency "pkg-config" (line 30)
  * C: 35: col 3: dependency "llvm@6" (line 35) should be put before dependency "pkg-config" (line 30)
  * C: 36: col 3: dependency "pcre" (line 36) should be put before dependency "pkg-config" (line 30)

@igas igas added audit failure CI fails while auditing the software needs response Needs a response from the issue/PR author labels Dec 26, 2018
@zegl zegl closed this Jan 28, 2019
@lock lock bot added the outdated PR was locked due to age label Feb 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
audit failure CI fails while auditing the software needs response Needs a response from the issue/PR author outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants