ts-node 8.0.3 (new formula) #37059

Maecenas · 2019-02-18T09:11:11Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Update 1: Fix failed checks by latest commits and by updating ts-node.

I was trying to add new formula ts-node and failed to resolve typescript module. I have tried to add a line of console.log(modules.path); to the head of /usr/local/bin/ts-node, in order to discover the require() method's module looking path. The output is:

[ '/usr/local/Cellar/ts-node/8.0.2/libexec/lib/node_modules/ts-node/dist/node_modules',
  '/usr/local/Cellar/ts-node/8.0.2/libexec/lib/node_modules/ts-node/node_modules',
  '/usr/local/Cellar/ts-node/8.0.2/libexec/lib/node_modules',
  '/usr/local/Cellar/ts-node/8.0.2/libexec/node_modules',
  '/usr/local/Cellar/ts-node/8.0.2/node_modules',
  '/usr/local/Cellar/ts-node/node_modules',
  '/usr/local/Cellar/node_modules',
  '/usr/local/node_modules',
  '/usr/node_modules',
  '/node_modules' ]

And the error occur, even after installing typescript to the /usr/local/Cellar/ts-node/8.0.2/libexec/lib/node_modules/typescript.

/usr/local/Cellar/ts-node
└── 8.0.2
    ├── INSTALL_RECEIPT.json
    ├── LICENSE
    ├── README.md
    ├── bin
    │   └── ts-node -> ../libexec/bin/ts-node
    └── libexec
        ├── bin
        │   ├── ts-node -> ../lib/node_modules/ts-node/dist/bin.js
        │   ├── tsc -> ../lib/node_modules/typescript/bin/tsc
        │   └── tsserver -> ../lib/node_modules/typescript/bin/tsserver
        └── lib
            └── node_modules
                ├── ts-node
                │   ├── LICENSE
                │   ├── README.md
                │   ├── dist
                │   ├── node_modules
                │   ├── package.json
                │   └── register
                └── typescript
                    ├── AUTHORS.md
                    ├── CODE_OF_CONDUCT.md
                    ├── CopyrightNotice.txt
                    ├── LICENSE.txt
                    ├── README.md
                    ├── ThirdPartyNoticeText.txt
                    ├── bin
                    ├── lib
                    └── package.json

13 directories, 17 files

javian · 2019-02-18T22:07:50Z

This audit needs to be corrected

09:14:09 ==> FAILED
09:14:09 Error: 2 problems in 1 formula detected
09:14:09 ts-node:
09:14:09   * C: 16: col 5: Use Language::Node for npm install args
09:14:09   * C: 27: col 75: Trailing whitespace detected.

javian · 2019-02-18T22:12:35Z

Formula/ts-node.rb

+  def install
+    system "npm", "install", *Language::Node.std_npm_install_args(libexec)
+    bin.install_symlink Dir["#{libexec}/bin/*"]
+    # Adding typescript to library's libexec


I don't understand why you need to do this. Shouldn't npm install install typescript already ?

I did this as I found that both brew install typescript and npm install typescript -g did not work for ts-node. I'm asking for help for any cases like this (that is, how to resolve external packages via npm install -g). Also, my humble understanding on how Node.js, npm and CommonJS modules work out seems not enough.

Another observation from package.json is that typescript is (perhaps intentionally) listed in peerDependencies and devDependencies.

TypeStrong/ts-node#765
https://github.com/TypeStrong/ts-node/blob/74147523da8853a41b70bf04578125e2d6f84731/package.json#L67-L70

Maecenas · 2019-02-19T06:32:53Z

This audit needs to be corrected

09:14:09 ==> FAILED
09:14:09 Error: 2 problems in 1 formula detected
09:14:09 ts-node:
09:14:09   * C: 16: col 5: Use Language::Node for npm install args
09:14:09   * C: 27: col 75: Trailing whitespace detected.

The trailing whitespace is easy to fix. But the other problem is under discussion.

chrmoritz · 2019-02-20T16:00:43Z

Maybe a better way for solving the typescript peerDependencies issue is to use the same trick we do for babel-cli (and webpack). Just put typescript in a resource and use a install method similar to:

homebrew-core/Formula/babel.rb

Lines 18 to 34 in da56cb0

    
           resource "babel-core" do 
        
             url "https://registry.npmjs.org/@babel/core/-/core-7.2.2.tgz" 
        
             sha256 "b632e5a565b000645d7bc0010331773481cc5dee7d4360360dccaa9e51c4785e" 
        
           end 
        
           def install 
        
             (buildpath/"node_modules/@babel/core").install resource("babel-core") 
        
             # declare babel-core as a bundledDependency of babel-cli 
        
             pkg_json = JSON.parse(IO.read("package.json")) 
        
             pkg_json["dependencies"]["@babel/core"] = resource("babel-core").version 
        
             pkg_json["bundledDependencies"] = ["@babel/core"] 
        
             IO.write("package.json", JSON.pretty_generate(pkg_json)) 
        
             system "npm", "install", *Language::Node.std_npm_install_args(libexec) 
        
             bin.install_symlink Dir["#{libexec}/bin/*"] 
        
           end

Remove trailing whitespace

Maecenas · 2019-02-21T03:33:43Z

@chrmoritz Thanks! I've commited as you suggested. However, I found ts-node is not be able to work unless to fix ts-node. The minor fix works great on my computer and is awaiting feedback.

Another question I had about pinning resources: would they be auto-updated by bots?

Formula/ts-node.rb

Co-Authored-By: Maecenas <[email protected]>

This reverts commit 25c1ee3.

Maecenas · 2019-03-07T07:57:35Z

@chrmoritz @javian Please review again if you are free. To fix I've proposed and merged a PR, and released a new version 8.0.3 of ts-node.

stale · 2019-03-28T09:49:49Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale · 2019-04-18T10:27:06Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

zbeekman · 2019-04-21T12:41:23Z

Can't all of this just be installed via npm install -g ...?

@Homebrew/maintainers sorry if I'm late to the party, but are we accepting node formulas these days?

Node formulae seem to have significant added complexity.

Maecenas · 2019-04-21T13:59:40Z

Thanks for replying!

Can't all of this just be installed via npm install -g ...?

I think so, (and believe that it would even be easier for most of the Formulas). But chances are that global installation for cli tools may cause other unintended problems. One reason I would like to have with homebrew is regular back up of installed packages.

@Homebrew/maintainers sorry if I'm late to the party, but are we accepting node formulas these days? Node formulae seem to have significant added complexity.

I followed the instructions at repo, but it hasn't been updated for some time.

MikeMcQuaid · 2019-04-21T16:12:43Z

but are we accepting node formulas these days?

Yes, we are. In this case, though, I don't think this is a good fit for inclusion because it's so specific to NodeJS. https://formulae.brew.sh/formula/alexjs on the other hand is an example of a useful library even if you use no other NodeJS stuff on your machine.

zbeekman · 2019-04-22T00:32:02Z

Sorry @Maecenas, at this time I don't think we can accept this formula in homebrew-core. You're welcome to create your own tap or search of another third party tap that may want to include it.

Sorry we didn't come to this conclusion earlier.

Thanks so much for your contributions, past, present and future to Homebrew. We REALLY value having a vibrant community with contributors like you! 💛

ts-node 8.0.2 (new formula)

2dad6e8

fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Feb 18, 2019

javian reviewed Feb 18, 2019

View reviewed changes

Maecenas mentioned this pull request Feb 19, 2019

brew audit --strict <formula> fail on macOS 10.14 Mojave Homebrew/brew#5767

Closed

5 tasks

Maecenas added 3 commits February 21, 2019 10:30

style: formatting

68c923c

Remove trailing whitespace

fix: import typescript as resource

d8163c6

test: fix test

64d9724

chrmoritz reviewed Feb 21, 2019

View reviewed changes

Formula/ts-node.rb Show resolved Hide resolved

fix: set NODE_PATH for search requirements

25c1ee3

Co-Authored-By: Maecenas <[email protected]>

chrmoritz approved these changes Feb 24, 2019

View reviewed changes

Maecenas mentioned this pull request Mar 7, 2019

feat: Add TypeScript local resolving TypeStrong/ts-node#793

Merged

Maecenas added 2 commits March 7, 2019 14:42

Revert "fix: set NODE_PATH for search requirements"

cc714f1

This reverts commit 25c1ee3.

ts-node 8.0.3

dd37943

Maecenas changed the title ~~ts-node 8.0.2 (new formula)~~ ts-node 8.0.3 (new formula) Mar 7, 2019

stale bot added the stale No recent activity label Mar 28, 2019

SMillerDev requested a review from javian March 28, 2019 10:18

stale bot removed the stale No recent activity label Mar 28, 2019

stale bot added the stale No recent activity label Apr 18, 2019

stale bot removed the stale No recent activity label Apr 21, 2019

zbeekman closed this Apr 22, 2019

lock bot added the outdated PR was locked due to age label May 22, 2019

lock bot locked as resolved and limited conversation to collaborators May 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ts-node 8.0.3 (new formula) #37059

ts-node 8.0.3 (new formula) #37059

Maecenas commented Feb 18, 2019 •

edited

Loading

javian commented Feb 18, 2019

javian Feb 18, 2019

Maecenas Feb 19, 2019 •

edited

Loading

Maecenas commented Feb 19, 2019

chrmoritz commented Feb 20, 2019 •

edited

Loading

Maecenas commented Feb 21, 2019 •

edited

Loading

Maecenas commented Mar 7, 2019 •

edited

Loading

stale bot commented Mar 28, 2019

stale bot commented Apr 18, 2019

zbeekman commented Apr 21, 2019

Maecenas commented Apr 21, 2019

MikeMcQuaid commented Apr 21, 2019

zbeekman commented Apr 22, 2019

ts-node 8.0.3 (new formula) #37059

ts-node 8.0.3 (new formula) #37059

Conversation

Maecenas commented Feb 18, 2019 • edited Loading

javian commented Feb 18, 2019

javian Feb 18, 2019

Choose a reason for hiding this comment

Maecenas Feb 19, 2019 • edited Loading

Choose a reason for hiding this comment

Maecenas commented Feb 19, 2019

chrmoritz commented Feb 20, 2019 • edited Loading

Maecenas commented Feb 21, 2019 • edited Loading

Maecenas commented Mar 7, 2019 • edited Loading

stale bot commented Mar 28, 2019

stale bot commented Apr 18, 2019

zbeekman commented Apr 21, 2019

Maecenas commented Apr 21, 2019

MikeMcQuaid commented Apr 21, 2019

zbeekman commented Apr 22, 2019

Maecenas commented Feb 18, 2019 •

edited

Loading

Maecenas Feb 19, 2019 •

edited

Loading

chrmoritz commented Feb 20, 2019 •

edited

Loading

Maecenas commented Feb 21, 2019 •

edited

Loading

Maecenas commented Mar 7, 2019 •

edited

Loading