Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio 4.2.1 #50339

Closed
wants to merge 2 commits into from
Closed

platformio 4.2.1 #50339

wants to merge 2 commits into from

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • Improved VSCode template with special forceInclude field for direct includes via -include flag (issue #3379)
  • Improved support of PIO Home on card-sized PC (Raspberry Pi, etc.) (issue #3313)
  • Froze "marshmallow" dependency to 2.X for Python 2 (issue #3380)
  • Fixed "TypeError: unsupported operand type(s)" when system environment variable is used by project configuration parser (issue #3377)
  • Fixed an issue when Library Dependency Finder (LDF) ignores custom "libLDFMode" and "libCompatMode" options in library.json
  • Fixed an issue when generating of compilation database "compile_commands.json" does not work with Python 2.7 (issue #3378)

@@ -13,7 +13,7 @@ class Platformio < Formula
sha256 "c6501bd561ee8d2b77037739484929eade3c4e15cb326b24b90634b32daecd32" => :high_sierra
end

depends_on "python@3.8"
depends_on "python@3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't support python 3.8 this should just be python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It supports Python 3.5+ including Python 3.8. I don't understand why we should install Python 3.8 hen Python 3.7 (python@3) is already installed? The same on my Mac machine: some tools depenend on Python 3 and some on Python 3.8. Why do I need multiple same Pythons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 84 line "virtualenv_create(libexec, "python3")" ok? The homebrew-pypi-poetadded it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tools depenend on Python 3 and some on Python 3.8. Why do I need multiple same Pythons?

Yes, everything that works with 3.8 will depend on that version. As soon as everything works with 3.8 you can remove 3.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge this?

Revert back Python 3.8 (I don't know why?)
@SMillerDev SMillerDev added the almost there PR is nearly ready to merge label Feb 17, 2020
@SMillerDev
Copy link
Member

Can you squash your commits?

@ivankravets
Copy link
Contributor Author

I created a new PR #50367

@lock lock bot added the outdated PR was locked due to age label Mar 22, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
almost there PR is nearly ready to merge outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants