-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platformio 4.2.1 #50339
platformio 4.2.1 #50339
Conversation
Formula/platformio.rb
Outdated
@@ -13,7 +13,7 @@ class Platformio < Formula | |||
sha256 "c6501bd561ee8d2b77037739484929eade3c4e15cb326b24b90634b32daecd32" => :high_sierra | |||
end | |||
|
|||
depends_on "python@3.8" | |||
depends_on "python@3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't support python 3.8 this should just be python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It supports Python 3.5+ including Python 3.8. I don't understand why we should install Python 3.8 hen Python 3.7 (python@3
) is already installed? The same on my Mac machine: some tools depenend on Python 3 and some on Python 3.8. Why do I need multiple same Pythons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 84 line "virtualenv_create(libexec, "python3")" ok? The homebrew-pypi-poet
added it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tools depenend on Python 3 and some on Python 3.8. Why do I need multiple same Pythons?
Yes, everything that works with 3.8 will depend on that version. As soon as everything works with 3.8 you can remove 3.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge this?
Revert back Python 3.8 (I don't know why?)
Can you squash your commits? |
I created a new PR #50367 |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?forceInclude
field for direct includes via-include
flag (issue #3379)