Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnuradio 3.8.1.0 #56628

Closed
wants to merge 2 commits into from
Closed

Gnuradio 3.8.1.0 #56628

wants to merge 2 commits into from

Conversation

LoPablo
Copy link

@LoPablo LoPablo commented Jun 21, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Comment on lines 8 to 10
head "https://github.com/gnuradio/gnuradio.git"
revision 15

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
head "https://github.com/gnuradio/gnuradio.git"
revision 15
head "https://github.com/gnuradio/gnuradio.git"

@jonchang jonchang requested a review from iMichka June 21, 2020 14:38
Co-authored-by: Jonathan Chang <[email protected]>
@iMichka
Copy link
Member

iMichka commented Jun 21, 2020

See my comments and the comments below: #49733 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants