Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile → 0.10.8 → 0.10.9 #58199

Closed
wants to merge 2 commits into from
Closed

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Jul 18, 2020

@request-info
Copy link

request-info bot commented Jul 18, 2020

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Jul 18, 2020
@SeekingMeaning SeekingMeaning removed the needs response Needs a response from the issue/PR author label Jul 18, 2020
@chenrui333
Copy link
Member

==> make
 cd . && bash /private/tmp/sile-20200718-2308-3tjws8/sile-0.10.8/missing automake-1.16 --foreign
/private/tmp/sile-20200718-2308-3tjws8/sile-0.10.8/missing: line 81: automake-1.16: command not found
WARNING: 'automake-1.16' is missing on your system.
         You should only need it if you modified 'Makefile.am' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'automake' program is part of the GNU Automake package:
         <https://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <https://www.gnu.org/software/autoconf>
         <https://www.gnu.org/software/m4/>
         <https://www.perl.org/>
make: *** [Makefile.in] Error 1

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jul 18, 2020
@alerque
Copy link
Contributor Author

alerque commented Jul 18, 2020

Not sure what happened there, but I'll look into it.

@alerque
Copy link
Contributor Author

alerque commented Jul 20, 2020

@chenrui333 I honestly can't make out what happened there. I can replicate the error when compiling the release tarball on a system without automake — which should work and does not so clearly something is wrong. The problem is I can't replicate the problem rebuilding the release tarball now.

In any event Lua 5.4 support has landed in master and a new release is immanent. I think I'll just update this PR to v0.10.9 when it gets tagged and move on.

@alerque
Copy link
Contributor Author

alerque commented Jul 24, 2020

@chenrui333 Looks like the v0.10.9 release fixed the build issue, CI tests at least are passing now. Anything else from me?

@gromgit
Copy link
Contributor

gromgit commented Jul 24, 2020

Anything else from me?

Fixing the PR title (sile 0.10.9) would be good. I seem to recall that various CI actions expect the title to be in a specific format, so individual creativity is not encouraged in this.

@SMillerDev
Copy link
Member

Anything else from me?

Fixing the PR title (sile 0.10.9) would be good. I seem to recall that various CI actions expect the title to be in a specific format, so individual creativity is not encouraged in this.

The PR title is fine, it's the commit that we would like in a certain format so we can easily find it.

@alerque
Copy link
Contributor Author

alerque commented Jul 24, 2020

@SMillerDev Thanks. I think I've followed the expected commit format, unless perhaps these should be squashed. I'm a bit confused on that requirement since my contributions are never used in the form of the original commits anyway, they are always some automatic rebase/squash. Is the (now obsolete) tag on the PR holding up the works?

@SMillerDev SMillerDev removed the build failure CI fails while building the software label Jul 24, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@alerque alerque deleted the sile-0.10.8 branch April 18, 2022 15:37
@github-actions github-actions bot added the outdated PR was locked due to age label May 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants