-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sile → 0.10.8 → 0.10.9 #58199
sile → 0.10.8 → 0.10.9 #58199
Conversation
Please provide a better issue/pull request title and/or description! |
|
Not sure what happened there, but I'll look into it. |
@chenrui333 I honestly can't make out what happened there. I can replicate the error when compiling the release tarball on a system without In any event Lua 5.4 support has landed in master and a new release is immanent. I think I'll just update this PR to v0.10.9 when it gets tagged and move on. |
@chenrui333 Looks like the v0.10.9 release fixed the build issue, CI tests at least are passing now. Anything else from me? |
Fixing the PR title ( |
The PR title is fine, it's the commit that we would like in a certain format so we can easily find it. |
@SMillerDev Thanks. I think I've followed the expected commit format, unless perhaps these should be squashed. I'm a bit confused on that requirement since my contributions are never used in the form of the original commits anyway, they are always some automatic rebase/squash. Is the (now obsolete) tag on the PR holding up the works? |
🤖 A scheduled task has triggered a merge. |
Upstream v0.10.8 release notes.
Upstream v0.10.9 release notes.