groff: patch for config.h bug #64842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you working on this actively at the moment? Because I had a look at the formula and can try to work on fixing it. I can make a PR on your fork so you can add the commits here if it helps. |
|
It works! ...after about 100 extra lines of diff patches. It's essentially all the same error. I decided to just open a new PR to save you the trouble of merging it onto your fork. Hope that's ok. Happy to close my newer PR if you'd rather do it here. |
BrewTestBot
pushed a commit
that referenced
this pull request
Nov 18, 2020
* groff: fix build See #65000 (comment) Builds on #64842 - [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/HEAD/CONTRIBUTING.md)? - [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change? - [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting? - [x] Is your test running fine `brew test <formula>`, where `<formula>` is the name of the formula you're submitting? - [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)? Newly added dependencies are for creating PDF and HTML files, and for recognising file encoding. * Update groff.rb * Update groff.rb Closes #65042. Co-authored-by: Jonathan Chang <[email protected]> Signed-off-by: Jonathan Chang <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64785
https://github.com/Homebrew/homebrew-core/runs/1401165131?check_suite_focus=true
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?