Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncompress: update download sha #66305

Closed
wants to merge 1 commit into from

Conversation

mitchblank
Copy link
Contributor

This was failing to build from source soley because the sha256 was incorrect for the tarball.

I don't have any direct knowledge of thie history of this package, but I suspect what happened is that the git history got rewritten per the comment here: vapier/ncompress#26 (comment) and that meant that github's generated tarball got changed slightly.

@vapier can you confirm this hunch?

This was failing to build from source soley because the sha256 was
incorrect for the tarball.

I don't have any direct knowledge of thie history of this package,
but I suspect what happened is that the git history got rewritten
per the comment here: vapier/ncompress#26 (comment)
and that meant that github's generated tarball got changed slightly.
@vapier
Copy link

vapier commented Dec 6, 2020

that is accurate. I renamed the old tags so the history is maintained, but the tarball for that specific tag is probably different since it points at a new commit history. the two should be identical if you unpack and compare.

sorry for the trouble.

@mitchblank
Copy link
Contributor Author

The automatic PR checks failed because it doesn't like this type of change:

==> FAILED
Error: 1 problem in 1 formula detected
ncompress:
  * stable sha256 changed without the url/version also changing; please create an issue upstream to rule out malicious circumstances and to find out why the file changed.

hopefully a project admin can override somehow; I don't know the process

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants