Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udptunnel: fix build on Xcode 12 #66310

Closed
wants to merge 1 commit into from
Closed

udptunnel: fix build on Xcode 12 #66310

wants to merge 1 commit into from

Conversation

mitchblank
Copy link
Contributor

  • The included configure script is too old to work now, so force an autoreconf
  • There are still some issues with Xcode 12's treatment of -Wimplicit-function-declaration as an error, so tweak CFLAGS too
  • It also was failing to download correctly because archive.org auto-gunzip'ed the response, breaking the sha256 check. The other provided mirror URL was even more broken, failing to negotiate an https connection. I found this voidlinux.org site that has the tarball with the expected sha though. None of this would be needed except that the original source of this package at cs.columbia.edu returns 404 if you try to access the URL over https instead of http.

@mitchblank
udptunnel: fix build on Xcode 12
009fd1d 
* The included configure script is too old to work now, so force
  an autoreconf

* There are still some issues with Xcode 12's treatment of
  -Wimplicit-function-declaration as an error, so tweak CFLAGS too

* It also was failing to download correctly because archive.org
  auto-gunzip'ed the response, breaking the sha256 check.  The
  other provided mirror URL was even more broken, failing to
  negotiate an https connection.  I found this voidlinux.org
  site that has the tarball with the expected sha though.

  None of this would be needed except that the original source of
  this package at cs.columbia.edu returns 404 if you try to
  access the URL over https instead of http.
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@mitchblank mitchblank mentioned this pull request Dec 7, 2020
Closed
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 6, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchblank @BrewTestBot @fxcoudert