Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkit: update revision to v0.8.0 tag's commit #66750

Closed
wants to merge 2 commits into from

Conversation

mikesep
Copy link
Contributor

@mikesep mikesep commented Dec 11, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

It appears that buildkit was retagged not long after this formula was bumped to v0.8.0 in #66110.

I'm not sure if the formula needs an additional revision 1 to make the difference between the original v0.8.0 clear.

It appears that buildkit was retagged not long after this formula was
bumped to v0.8.0.
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Dec 11, 2020
@carlocab
Copy link
Member

Thanks, @mikesep.

@carlocab carlocab mentioned this pull request Dec 11, 2020
@fxcoudert fxcoudert added the checksum mismatch SHA-256 doesn't match the download label Dec 11, 2020
@fxcoudert
Copy link
Member

I requires a revision bump, yes. But most importantly, it requires confirmation from upstream that they indeed meant to retag, and that it was not done in error or maliciously.

@mikesep mikesep force-pushed the buildkit-v0.8.0-retag branch from 2cfe788 to 0e68669 Compare December 11, 2020 22:17
@mikesep
Copy link
Contributor Author

mikesep commented Dec 12, 2020

@tonistiigi, a member of the BuildKit repo, says

Yes, this is correct. The commit at v0.8.0~1 was tagged for an hour or so but we couldn't release it because of a pipeline issue.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@mikesep mikesep deleted the buildkit-v0.8.0-retag branch December 12, 2020 15:48
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 12, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
checksum mismatch SHA-256 doesn't match the download go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants