Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pumba: fix sha256 mismatch #67073

Closed
wants to merge 1 commit into from
Closed

pumba: fix sha256 mismatch #67073

wants to merge 1 commit into from

Conversation

arbourd
Copy link
Contributor

@arbourd arbourd commented Dec 17, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

SHA mismatch. Author re-released 0.7.7. Clarification issue here: alexei-led/pumba#190

Some details:

Screen Shot 2020-12-17 at 3 25 52 PM

  • I have confirmed that the tarball is the new 0.7.7 release from Github

Related to #66355

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Dec 17, 2020
@arbourd arbourd mentioned this pull request Dec 17, 2020
@carlocab
Copy link
Member

Thanks for opening this. I've been meaning to get around to it. Your commit message is the wrong way around, though. It should be pumba: fix not fix: pumba.

The message could be more informative too. Maybe pumba: fix sha256 mismatch?

@arbourd arbourd changed the title fix: pumba pumba: fix Dec 17, 2020
@arbourd arbourd changed the title pumba: fix pumba: fix sha256 mismatch Dec 17, 2020
@Rylan12 Rylan12 added checksum mismatch SHA-256 doesn't match the download do not merge labels Dec 17, 2020
@Rylan12
Copy link
Member

Rylan12 commented Dec 17, 2020

Thanks for the PR, @arbourd, and for the upstream issues @carlocab!

Marking as do not merge until we get confirmation from them that this was intentional.

SHA mismatch. Author re-released 0.7.7
license "Apache-2.0"
revision 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a revision so it will be rebuilt, and reinstalled.

As per my investigation, the build process had changed between 0.7.7 releases and it is probably best to ensure the binary is fresh.

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@arbourd arbourd deleted the fix-pumba branch December 18, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checksum mismatch SHA-256 doesn't match the download go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants