Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedgnuplot: fix big sur build #67832

Closed

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

As discussed with #66370 (comment) Big Sur's system perl changed how PREFIX= is treated as an install destination. The more explicit way to control MakeMaker is to set INSTALL_BASE instead, which should result in consistent behavior between different OS/X versions.

cc @mitchblank

@chenrui333 chenrui333 added license License PRs CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. labels Dec 28, 2020
@BrewTestBot BrewTestBot added the perl Perl use is a significant feature of the PR or issue label Dec 28, 2020
@mitchblank
Copy link
Contributor

I don't understand why you needed to make a new PR when #66370 is already open? Looks like mostly the same changes..

@chenrui333
Copy link
Member Author

i am sorry, that is my bad, I did not see the change. Closing.

@chenrui333 chenrui333 closed this Dec 28, 2020
@chenrui333
Copy link
Member Author

move the changes to there, thanks @mitchblank!

@chenrui333 chenrui333 deleted the feedgnuplot-fix-big-sur-build branch December 18, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. license License PRs perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants