-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{gdal,glew}: revision bumps #68039
{gdal,glew}: revision bumps #68039
Conversation
14630fd
to
bda4d8f
Compare
CI failure looks related to #68049. |
bda4d8f
to
cffc6d5
Compare
On Mojave:
This is looking a lot like a mismatched SDK problem too. @fxcoudert, do you know how to fix this? Is it enough to just set
? Logs: https://github.com/Homebrew/homebrew-core/pull/68039/checks?check_run_id=1628381872 |
Big Sur error is related to the disappearance of |
cffc6d5
to
17b8672
Compare
I'm also wondering if this can be removed: Lines 142 to 147 in 530732c
|
Comment says yes |
The comment is also ambiguous about whether it's talking about Homebrew support for Sierra (yes), or |
Definitely homebrew support, we don't really care what upstream supports (and we're also not going to patch it for versions that homebrew doesn't support) |
3e617f0
to
b95ee40
Compare
b95ee40
to
c0abdb5
Compare
Ok, so I've managed to fix the Mojave CI failure, though I don't know if it's the right fix. poke @fxcoudert (again, sorry) |
I think, if there is a SDK issue with curl on Mojave, depending on our own curl is probably best. |
Fixes #68038, #68049.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?