Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{gdal,glew}: revision bumps #68039

Closed
wants to merge 2 commits into from
Closed

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 30, 2020

Fixes #68038, #68049.


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@carlocab
Copy link
Member Author

CI failure looks related to #68049.

@carlocab carlocab changed the title glew: revision to fix OpenGL path {gdal,glew}: revision bumps Dec 31, 2020
@carlocab
Copy link
Member Author

carlocab commented Dec 31, 2020

On Mojave:

==> /usr/local/opt/[email protected]/bin/python3 -c import osgeo.gdal
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/osgeo/__init__.py", line 18, in swig_import_helper
    return importlib.import_module(mname)
  File "/usr/local/Cellar/[email protected]/3.9.1_3/Frameworks/Python.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 666, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 565, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 1108, in create_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
ImportError: dlopen(/usr/local/lib/python3.9/site-packages/osgeo/_gdal.cpython-39-darwin.so, 2): Symbol not found: _curl_mime_addpart
  Referenced from: /usr/local/Cellar/gdal/3.2.0_2/lib/libgdal.28.dylib
  Expected in: /usr/lib/libcurl.4.dylib
 in /usr/local/Cellar/gdal/3.2.0_2/lib/libgdal.28.dylib

This is looking a lot like a mismatched SDK problem too. @fxcoudert, do you know how to fix this? Is it enough to just set

ENV["ac_cv_func_curl_mime_addpart"] = "no" if MacOS.version == :mojave

?

Logs: https://github.com/Homebrew/homebrew-core/pull/68039/checks?check_run_id=1628381872

@carlocab
Copy link
Member Author

carlocab commented Dec 31, 2020

Big Sur error is related to the disappearance of MacOSX11.0.sdk on the latest Big Sur. In progress at #67615.

@carlocab
Copy link
Member Author

I'm also wondering if this can be removed:

# Work around "error: no member named 'signbit' in the global namespace"
# Remove once support for macOS 10.12 Sierra is dropped
if DevelopmentTools.clang_build_version >= 900
ENV.delete "SDKROOT"
ENV.delete "HOMEBREW_SDKROOT"
end

@SMillerDev
Copy link
Member

SMillerDev commented Dec 31, 2020

# Remove once support for macOS 10.12 Sierra is dropped 

Comment says yes

@carlocab
Copy link
Member Author

The comment is also ambiguous about whether it's talking about Homebrew support for Sierra (yes), or gdal support for Sierra (dunno). Though I guess Homebrew support is a safe assumption.

@SMillerDev
Copy link
Member

Definitely homebrew support, we don't really care what upstream supports (and we're also not going to patch it for versions that homebrew doesn't support)

@carlocab carlocab force-pushed the glew-revision branch 2 times, most recently from 3e617f0 to b95ee40 Compare December 31, 2020 12:33
@carlocab
Copy link
Member Author

Ok, so I've managed to fix the Mojave CI failure, though I don't know if it's the right fix. poke @fxcoudert (again, sorry)

@fxcoudert
Copy link
Member

I think, if there is a SDK issue with curl on Mojave, depending on our own curl is probably best.

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@carlocab carlocab deleted the glew-revision branch December 31, 2020 15:30
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 31, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glew-targets.cmake points to wrong OpenGL location on MacOS Big Sur
4 participants